Skip to content

Conversation

@CliffyWong
Copy link
Contributor

@CliffyWong CliffyWong commented Dec 11, 2025

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
image

Summary

This PR is for updating the threshold of several smb TH6 related sensors

Motivation

This PR includes the following changes:
1.Update the max alarm threshold of SMB_VDDCORE&SMB_ASIC_VOLTAGE iout sensors based on the sensors hardware design for TH6 B0+.
Updated sensor list:
SMB_PU2978_XP0R8V_TH6_VDDC_IOUT
SMB_PU1342_XP0R8V_PT_VDDC_1_IOUT
SMB_PU1502_XP0R75V_TH6_TRVDD_0_IOUT
SMB_PU1502_XP0R8V_PT_VDDC_2_IOUT
SMB_PU2056_XP0R8V_PT_VDDC_3_IOUT
SMB_PU2056_XP0R8V_PT_VDDC_4_IOUT
SMB_PU1937_XP0R8V_PT_VDDC_5_IOUT
SMB_PU2052_XP0R8V_PT_VDDC_6_IOUT
SMB_PU1745_XP0R8V_PT_VDDC_7_IOUT

2.Update the min alarm threshold of iin/iout sensors since vendor suggested :
"About negative current during 0A load,this is due to Imon accuracy. In this application, IIN is calculated based Vin,Vout,Iout and register setting in the Input Power Estimate Settings.
image (2)

Therefore , adjust lower threshold as:

  • 0.5A* phase number to cover the negative current issue when 0A.
  • 0W as the lower threshold for PIN/POUT."

updated sensor list:
MCB_PU1497_XP3R3V_OSFP_IIN/OUT
MCB_PU1497_XP3R3V_OSFP_POUT
SMB_PU2978_XP0R8V_TH6_VDDC_IIN/IOUT
SMB_PU2203_XP0R8V_PT_VDDC_0_IIN/IOUT
SMB_PU2203_XP0R72V_PB_TRVDD_0_IIN/IOUT
SMB_PU1502_XP0R75V_TH6_TRVDD_0_IIN/IOUT
SMB_PU1502_XP0R8V_PT_VDDC_2_IIN/IOUT
SMB_PU2056_XP0R8V_PT_VDDC_3_IIN/IOUT
SMB_PU2056_XP0R8V_PT_VDDC_4_IIN/IOUT
SMB_PU1745_XP0R8V_PT_VDDC_7_IIN/IOUT
SMB_PU1745_XP0R72V_PB_TRVDD_2_IIN/IOUT
SMB_PU1342_XP0R8V_PT_VDDC_1_IIN/IOUT
SMB_PU1342_XP1R5V_TH6_RVDD_0_IIN/IOUT
SMB_PU2052_XP0R8V_PT_VDDC_6_IIN/IOUT
SMB_PU2052_XP1R5V_TH6_RVDD_1_IIN/IOUT
SMB_PU1937_XP0R75V_TH6_TRVDD_1_IIN/IOUT
SMB_PU1937_XP0R8V_PT_VDDC_5_IIN/IOUT
SMB_PU1497_XP0R9V_TH6_TRVDD_0_IIN/IOUT
SMB_PU1497_XP0R72V_PB_TRVDD_1_IIN/IOUT
SMB_PU1746_XP0R9V_TH6_TRVDD_1_IIN/IOUT
SMB_PU1746_XP0R72V_PB_TRVDD_3_IIN/IOUT

Test Plan

1.Run platform_manager/sensor_service/fan_service/data_corral_service on the device successfully, used sensor_service_client to catch the snapshot of sensors:
image

Pls refer the full logs: PM Services.zip

2.Run all hw_test cases, passed.
Pls refer the full logs: HwTest.zip

@meta-cla meta-cla bot added the CLA Signed label Dec 11, 2025
@CliffyWong CliffyWong marked this pull request as ready for review December 11, 2025 06:08
@meta-codesync
Copy link

meta-codesync bot commented Dec 23, 2025

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D89735558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant