Skip to content

Conversation

@sunnyshen321
Copy link

Summary:
Changes:

  • Added validate_array method to all Parameter classes for reusable vectorized validation
  • Added check_membership_df method to SearchSpace class for batch membership checking on DataFrames
  • Null values handling consistent with existing validate() and check_membership() methods

Differential Revision: D90637436

Summary:
Changes:
- Added `validate_array` method to all Parameter classes for reusable vectorized validation
- Added `check_membership_df` method to SearchSpace class for batch membership checking on DataFrames
- Null values handling consistent with existing `validate()` and `check_membership()` methods

Differential Revision: D90637436
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 14, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 14, 2026

@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90637436.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 95.69892% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.72%. Comparing base (a663f58) to head (7d4b840).

Files with missing lines Patch % Lines
ax/core/search_space.py 93.18% 3 Missing ⚠️
ax/core/parameter.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4762   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files         582      582           
  Lines       60748    60839   +91     
=======================================
+ Hits        58758    58848   +90     
- Misses       1990     1991    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants