Migration to Noise module #4761
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
=======================================
Coverage 96.72% 96.73%
=======================================
Files 582 584 +2
Lines 60742 60815 +73
=======================================
+ Hits 58754 58827 +73
Misses 1988 1988 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
January 13, 2026 14:08
…acebook#4687) Summary: Adjustment after discussion in D89407340. Changing optimization trace to return underlying noiseless value instead of noisy for custom noise functions. Reviewed By: Balandat Differential Revision: D89544093 Privacy Context Container: L1307644
Summary: T249209321 Introduces a unified Noise abstraction for benchmark problems, replacing the split responsibility between noise_std on BenchmarkProblem and add_custom_noise on BenchmarkTestFunction. Adds two noise implementations: GaussianNoise - standard IID Gaussian noise with configurable noise_std GaussianMixtureNoise - mixture of Gaussians for heteroskedastic problems Subsequent diff migrates current benchmarking to incorporate these changes. Differential Revision: D90596997
Summary: Updates `benchmark.py` to use the new Noise module architecture: passes `problem.noise` instead of `problem.noise_std` to `BenchmarkRunner`, and removes the obsolete `add_custom_noise` replacement since noise is now handled entirely by the `Noise` object on the runner. Differential Revision: D90597013
hvarfner
force-pushed
the
export-D90597013
branch
from
b35679b to
f3c643c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates
benchmark.pyto use the new Noise module architecture: passesproblem.noiseinstead ofproblem.noise_stdtoBenchmarkRunner, and removes the obsoleteadd_custom_noisereplacement since noise is now handled entirely by theNoiseobject on the runner.Differential Revision: D90597013