Skip to content

Document intentional suppress_filters on the DSAR cleanup query#175

Merged
fabiodalez-dev merged 1 commit into
mainfrom
chore/suppress-filters-phpcs-ignore
Jul 2, 2026
Merged

Document intentional suppress_filters on the DSAR cleanup query#175
fabiodalez-dev merged 1 commit into
mainfrom
chore/suppress-filters-phpcs-ignore

Conversation

@fabiodalez-dev

Copy link
Copy Markdown
Owner

Summary

A broad Plugin Check run (WordPressVIPMinimum ruleset, beyond the wp.org plugin_repo gate) flags one ERROR: WordPressVIPMinimum.Performance.WPQueryParams.SuppressFilters at the DSAR retention-cleanup query in class-activator.php.

suppress_filters => true there is intentional: this internal housekeeping query must find and delete every expired faz_dsar record regardless of third-party query filters (e.g. a multilingual plugin scoping queries by language), so flipping it to false could leave expired records behind — a correctness regression, not a fix. Documented with a callsite phpcs:ignore + rationale instead.

Notes

  • Not a wp.org blocker: suppress_filters is a WordPressVIPMinimum sniff and is NOT in the plugin_repo Plugin Check category that wp.org review uses (verified). This only keeps a broader/VIP lint run clean.
  • No behaviour change.

…leanup query

Silences WordPressVIPMinimum.Performance.WPQueryParams.SuppressFilters with a
callsite phpcs:ignore + rationale: the faz_dsar retention cleanup must delete
every expired record regardless of third-party query filters (multilingual
scoping etc.), so suppress_filters=true is deliberate. Not a wp.org plugin_repo
error (VIP-only sniff); this just keeps a broader lint run clean.
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fabiodalez-dev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5bdb5778-e0ee-4162-89e5-ecdd661800fa

📥 Commits

Reviewing files that changed from the base of the PR and between 4635e8a and 38331ff.

📒 Files selected for processing (1)
  • includes/class-activator.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/suppress-filters-phpcs-ignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fabiodalez-dev fabiodalez-dev merged commit 3499438 into main Jul 2, 2026
5 checks passed
@fabiodalez-dev fabiodalez-dev deleted the chore/suppress-filters-phpcs-ignore branch July 2, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant