Document intentional suppress_filters on the DSAR cleanup query#175
Conversation
…leanup query Silences WordPressVIPMinimum.Performance.WPQueryParams.SuppressFilters with a callsite phpcs:ignore + rationale: the faz_dsar retention cleanup must delete every expired record regardless of third-party query filters (multilingual scoping etc.), so suppress_filters=true is deliberate. Not a wp.org plugin_repo error (VIP-only sniff); this just keeps a broader lint run clean.
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
A broad Plugin Check run (WordPressVIPMinimum ruleset, beyond the wp.org
plugin_repogate) flags one ERROR:WordPressVIPMinimum.Performance.WPQueryParams.SuppressFiltersat the DSAR retention-cleanup query inclass-activator.php.suppress_filters => truethere is intentional: this internal housekeeping query must find and delete every expiredfaz_dsarrecord regardless of third-party query filters (e.g. a multilingual plugin scoping queries by language), so flipping it tofalsecould leave expired records behind — a correctness regression, not a fix. Documented with a callsitephpcs:ignore+ rationale instead.Notes
suppress_filtersis a WordPressVIPMinimum sniff and is NOT in theplugin_repoPlugin Check category that wp.org review uses (verified). This only keeps a broader/VIP lint run clean.