[Fix] Do not set axes grid center position #2824#2947
[Fix] Do not set axes grid center position #2824#2947mwestphal merged 6 commits intof3d-app:masterfrom
Conversation
mwestphal
left a comment
There was a problem hiding this comment.
Some questions, please, whenever you need, ask for a review using github feature top right.
|
\ci fast |
|
\ci full |
|
please rebase on latest master @cuongdv-20 |
|
You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI. |
|
rebase is incorrect, please read up on rebase: https://thepugautomatic.com/2017/02/interactive-rebase-against-the-remote-master/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2947 +/- ##
=======================================
Coverage 97.12% 97.13%
=======================================
Files 206 206
Lines 16411 16455 +44
=======================================
+ Hits 15939 15983 +44
Misses 472 472 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
47b7289 to
8026282
Compare
|
\ci full |
mwestphal
left a comment
There was a problem hiding this comment.
LGTM, lets see what CI says.
|
CI is clean, lets merge |
|
Thanks for your contribution @cuongdv-20 ! |
* do not set axes grid center position * update test interaction * Not use interaction test * do not set axes grid center position * update test interaction * Not use interaction test
* do not set axes grid center position * update test interaction * Not use interaction test * do not set axes grid center position * update test interaction * Not use interaction test
Describe your changes
Function ConfigureGridAxesUsingCurrentActors() sets the grid axes position to center of bounding box
This will shift the axes grid toward center of the object, but apply grid bound from object's bounding box.
The problem occurs to all objects that are deviated to one side of the axis
Issue ticket number and link if any
#2824
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.