Skip to content

Add TIME_STEPS to RequestInformation to AlembicReader#2791

Open
LuTheDog wants to merge 11 commits intof3d-app:masterfrom
LuTheDog:timesteps-from-alembic-reader
Open

Add TIME_STEPS to RequestInformation to AlembicReader#2791
LuTheDog wants to merge 11 commits intof3d-app:masterfrom
LuTheDog:timesteps-from-alembic-reader

Conversation

@LuTheDog
Copy link
Copy Markdown

@LuTheDog LuTheDog commented Jan 7, 2026

Describe your changes

Issue ticket number and link if any

#2734

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

Comment thread plugins/alembic/module/vtkF3DAlembicReader.cxx
Comment thread plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated
Comment thread plugins/alembic/module/vtkF3DAlembicReader.cxx
Comment thread plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, that looks good, lets add a test then :)

@LuTheDog LuTheDog changed the title DRAFT: Add TIME_STEPS to RequestInformation to AlembicReader Add TIME_STEPS to RequestInformation to AlembicReader Feb 14, 2026
@LuTheDog LuTheDog marked this pull request as ready for review February 14, 2026 13:16
@LuTheDog
Copy link
Copy Markdown
Author

\ci fast

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 14, 2026

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@LuTheDog LuTheDog force-pushed the timesteps-from-alembic-reader branch 2 times, most recently from 3ed4998 to 10b2cb8 Compare February 14, 2026 13:54
@LuTheDog
Copy link
Copy Markdown
Author

\ci full

@LuTheDog LuTheDog force-pushed the timesteps-from-alembic-reader branch from ce904ca to fd88bb6 Compare March 14, 2026 15:18
@mwestphal
Copy link
Copy Markdown
Member

Still working on this @LuTheDog ?

@LuTheDog
Copy link
Copy Markdown
Author

I was, but I've been having less and less free time. It's mostly done, but one of the tests fails because of a slowdown, which needs to be debugged.

@mwestphal
Copy link
Copy Markdown
Member

Can you provide steps to reproduce the issue ?

@LuTheDog
Copy link
Copy Markdown
Author

Just running the ci tests does it, locally or remotely

@mwestphal
Copy link
Copy Markdown
Member

Just running the ci tests does it, locally or remotely

Are you talking about this failure ?

893: Test command: /__w/f3d/f3d/source/bin/f3d "/__w/f3d/f3d/source/testing/data/xform_anim.abc" "-g" "--animation-time=1.5" "--animation-progress" "--no-config" "--resolution=300,300" "--output=/__w/f3d/f3d/source/Testing/Temporary/TestAlembicAnimationXForm.png" "--reference=/__w/f3d/f3d/source/testing/baselines/TestAlembicAnimationXForm.png" "--rendering-backend=auto" "--load-plugins=alembic"
893: Working Directory: /__w/f3d/f3d/source/application/testing
893: Environment variables: 
893:  F3D_PLUGINS_PATH=/__w/f3d/f3d/source/lib
893:  CTEST_F3D_PROGRESS_BAR=1
893:  CTEST_F3D_FORCE_DPI_SCALE=1.0
893: Test timeout computed to be: 30
893: No animation available, cannot load a specific animation time
893: Current rendering difference with reference image: 0.51668 is higher than the threshold of 0.04.
893: 
1/2 Test #893: f3d::TestAlembicAnimationXForm ...........***Failed    0.70 sec
test 894
    Start 894: f3d::TestAlembicAnimationXFormRotation

894: Test command: /__w/f3d/f3d/source/bin/f3d "/__w/f3d/f3d/source/testing/data/joint1.abc" "-g" "--animation-time=1.5" "--animation-progress" "--no-config" "--resolution=300,300" "--output=/__w/f3d/f3d/source/Testing/Temporary/TestAlembicAnimationXFormRotation.png" "--reference=/__w/f3d/f3d/source/testing/baselines/TestAlembicAnimationXFormRotation.png" "--rendering-backend=auto" "--load-plugins=alembic"
894: Working Directory: /__w/f3d/f3d/source/application/testing
894: Environment variables: 
894:  F3D_PLUGINS_PATH=/__w/f3d/f3d/source/lib
894:  CTEST_F3D_PROGRESS_BAR=1
894:  CTEST_F3D_FORCE_DPI_SCALE=1.0
894: Test timeout computed to be: 30
894: Animation time 1.5 is outside of range [0, 0.04], using 0.04.
894: Current rendering difference with reference image: 0.467808 is higher than the threshold of 0.04.
894: 
2/2 Test #894: f3d::TestAlembicAnimationXFormRotation ...***Failed    0.70 sec

0% tests passed, 2 tests failed out of 2

Label Time Summary:
abc            =   1.41 sec*proc (2 tests)
alembic        =   1.41 sec*proc (2 tests)
application    =   1.41 sec*proc (2 tests)
plugin         =   1.41 sec*proc (2 tests)

Total Test time (real) =   1.45 sec

The following tests FAILED:
	893 - f3d::TestAlembicAnimationXForm (Failed)           abc alembic application plugin
	894 - f3d::TestAlembicAnimationXFormRotation (Failed)   abc alembic application plugin

?

@LuTheDog
Copy link
Copy Markdown
Author

Exactly

@mwestphal mwestphal self-assigned this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for recovering keyframes/timesteps in vtkF3DAlembicReader

3 participants