Skip to content

Fix/issue 018 resolved anchor types#279

Open
ezedike-evan wants to merge 9 commits into
mainfrom
fix/issue-018-resolved-anchor-types
Open

Fix/issue 018 resolved anchor types#279
ezedike-evan wants to merge 9 commits into
mainfrom
fix/issue-018-resolved-anchor-types

Conversation

@ezedike-evan

Copy link
Copy Markdown
Owner

Summary

Linked issue

Closes #

Changes

Testing notes

Automated

  • npm run typecheck · ⏳ not run / ✅ green / ❌ failing
  • npm run lint · ⏳ not run / ✅ green / ❌ failing
  • npm run test · ⏳ not run / ✅ green / ❌ failing
  • npm run build · ⏳ not run / ✅ green / ❌ failing

New / modified tests

Manual verification (if applicable)

Screenshots / recordings

Before After

Checklist

Correctness

  • The PR title follows Conventional Commits (auto-linted)
  • One logical change; unrelated cleanup was split into a separate PR
  • npm run typecheck passes
  • npm run lint passes with zero new warnings (we run --max-warnings 0 in CI)
  • npm run test passes; new behaviour has a test
  • npm run build passes

Data integrity

  • No fabricated rates, stub prices, or placeholder exchange rates (see issue.md #005)
  • No isMock, // MOCK, // TODO: replace with real data, or commented-out real code
  • If touching an anchor: the anchor's stellar.toml is publicly resolvable at https://{domain}/.well-known/stellar.toml and contains TRANSFER_SERVER_SEP0024
  • If touching SEP-10: network passphrase assertion is intact (mainnet only)
  • If touching SEP-24: the 10s AbortController timeout is intact on anchor fetches
  • If touching the status poll: terminal states (completed | refunded | error) still stop the SWR loop

Security & non-custody (see docs/NON_CUSTODY.md once it lands)

  • No new code path holds user keys, user funds, or long-lived anchor JWTs
  • Every signing action is performed by the user's wallet (Freighter today)
  • No secrets committed; .env.local is unchanged; new env vars are added to .env.example

Docs

  • User-facing behaviour change → CHANGELOG.md entry under [Unreleased]
  • API / schema change → relevant docs/*.md updated in the same PR
  • Architecture change → docs/ARCHITECTURE.md updated (file map, diagram, or invariants as applicable)
  • Public-facing feature → screenshot added to docs/showcase/images/ when relevant
  • New env var → .env.example + README env table updated

Release hygiene

  • If this touches a wave deliverable, the matching [ ] in docs/ROADMAP.md is updated
  • No dependency added without justification in the PR description
  • No breaking change hidden inside a non-breaking commit

Breaking changes

None.

For reviewers

ritik4ever and others added 8 commits April 26, 2026 17:23
- Accept AnchorCapabilities and evaluate sep24/sep38 flags
- Short-circuit with `source: 'unavailable'` without making network calls
- Add tests to ensure 0 requests are made when capabilities are lacking
- Elevate `ResolvedAnchor` in `types/index.ts` to extend `Anchor` with strict `capabilities`
- Update `resolveAllAnchors` to return cleanly formed `ResolvedAnchor`s
- Make `DiscoveredAnchor` extend `ResolvedAnchor`
- Switch `useAnchorRates` to reliably accept the whole `ResolvedAnchor`
- Upgrade capability gating test mocks to furnish full phantom `ResolvedAnchor` objects
…, amount sanitisation, corridor expansion, anchor registry consolidation
@vercel

vercel Bot commented May 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stellar-intel Error Error May 30, 2026 2:43pm

Add 'Planned' status banners to SDK, MCP, and INTENT_API so readers know
these describe intended surfaces, not shipped code. Add a 'what ships today'
note to the README and drop the missing hero image. Create the
CANONICAL_JSON, NON_CUSTODY, and JURISDICTIONAL stub docs that existing
links referenced.
@ezedike-evan

Copy link
Copy Markdown
Owner Author

Sprint Review — NOT READY TO MERGE

Critical: PR template left blank

The body was submitted as an unfilled template. Every required section is empty or contains only placeholder text:

  • Linked issue: Closes # with nothing after it — this PR has no linked issue. The branch name references issue [#018] AnchorCapabilities and ResolvedAnchor types #18, which is already closed (merged), so this PR appears to be either a duplicate or follow-on work that needs its own tracking issue.
  • Summary: No description of what changed or why.
  • Changes: Bullet list is empty (- with no content).
  • Testing notes: All automated checks marked ⏳ not run.
  • Checklist: Every box is unchecked.

Required fixes before this can merge:

  1. Open a new issue (or reuse an existing open one) that this PR closes, and link it with a closing keyword (Closes #NNN).
  2. Fill in the Summary — one or two sentences on what changed and why. The PR touches a lot of ground (husky pre-push hook, ESLint config rewrite, ResolvedAnchor type fix, ExecuteDrawer callback, 4 new doc files, capability-gate tests) — a reviewer cannot assess scope without a summary.
  3. Fill in the Changes list with file-level bullets.
  4. Run npm run typecheck, npm run lint, npm run test, npm run build and tick (or ❌) each box with the actual result.
  5. Fix the PR titleFix/issue 018 resolved anchor types does not follow Conventional Commits (fix(types): … would pass the linter). The title linter will fail CI.

Substantive notes (for when the template is filled in):

  • better-sqlite3 is a native addon. Confirm it stays as a devDependency only and that the production Next.js bundle does not import lib/reputation/db.ts at runtime.
  • The _seedOutcomeStore export in route.ts is test-only but lives in a production route file. A comment above it is fine for now, but consider moving the seed helper to a test utility in a follow-up so it cannot be accidentally called from production code.

Please address the template and CI items, then re-request review.

@ezedike-evan

Copy link
Copy Markdown
Owner Author

Sprint re-review — still blocked on the same three issues flagged last cycle.

1. Title does not follow Conventional Commits.
Fix/issue 018 resolved anchor types is not a valid title. The linter (.github/workflows/pr-title.yml) requires the form <type>(<optional scope>): <description> where type is one of feat | fix | docs | refactor | test | chore | ci | perf | build | style | revert. Please rename to something like:

fix(types): resolve AnchorCapabilities and ResolvedAnchor types (#018)

2. Linked issue section is blank.
The body still has Closes # with no number filled in. Issue #18 ([#18] AnchorCapabilities and ResolvedAnchor types) is closed, but you still need to explicitly link it (e.g. Closes #18) so the relationship is tracked and CI can confirm the work is scoped.

3. PR is CONFLICTING against main.
mergeStateStatus: DIRTY — the branch needs a rebase before it can be merged.

Action items:

  • Rename the PR title to a valid Conventional Commits string
  • Add Closes #18 (or the correct issue number) to the Linked issue section
  • git fetch origin && git rebase origin/main, resolve conflicts, force-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants