Repository navigation
add sse-c support for the s3 download_file function - #335
Open
flaviogrossi wants to merge 1 commit into
Open
flaviogrossi wants to merge 1 commit into
flaviogrossi wants to merge 1 commit into
Conversation
add encyption option in s3 download_file function and send sse-c headers in the request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
it seems that the
S3.download_file()function does not support adding SSE-C headers via an options argument.The following patch adds support for this, just like the
get_object()function does.I think this is useful because the former is an higher level function than the latter and allows things like not storing the entire file in memory while downloading, etc.