feat: validate @types packages before installing them#2
Open
forivall wants to merge 4 commits intoewgenius:developfrom
Open
feat: validate @types packages before installing them#2forivall wants to merge 4 commits intoewgenius:developfrom
forivall wants to merge 4 commits intoewgenius:developfrom
Conversation
will check if the package exists and is not deprecated
Owner
|
@forivall good idea, thanks! Are you planning to continue working on it? |
Author
|
I feel like it can be merged as-is, as long as you're fine with the option aliases. I also haven't checked your changes since, so if this needs conflict resolution, i'll be able to do that. also, the type definition for |
Author
|
Oh yeah, improve the messages, that was the main thing to add |
Author
|
and to submit the typings to definitely typed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will check if the package exists and is not deprecated
still kinda work in progress, in particular, with the option aliases