Map cosmos-sdk pruning config to ev-node format and remove sonic dependency by Copilot · Pull Request #345 · evstack/ev-abci

Copilot · 2026-02-17T09:34:18Z

Implementation Plan

1. Update pruning configuration mapping in `server/start.go`

Rename clearConflictingViperKeys to mapCosmosPruningToEvNode
Implement proper mapping from cosmos-sdk pruning keys to ev-node format:
- Map pruning → evnode.pruning.pruning_mode with value conversion:
  - "default" → "all"
  - "nothing" → "disabled"
  - "everything" → "all"
  - "custom" → "all"
  - unknown → "metadata"
- Map pruning-keep-recent → evnode.pruning.pruning_keep_recent
- Map pruning-interval → evnode.pruning.pruning_interval (with block-to-duration conversion)
Use cosmos-sdk server flag constants (FlagPruning, FlagPruningKeepRecent, FlagPruningInterval) instead of hardcoded strings
Add tests for the mapping function
Address all code review feedback

2. Remove sonic dependency from Dockerfiles

Remove sonic installation from Dockerfile (line 31)
Remove sonic installation from Dockerfile.cosmos-sdk (line 32)
Remove sonic installation from tests/integration/docker/Dockerfile.gm (line 37)

3. Testing and Validation

Run unit tests for server package - All pass ✅
Verify builds work correctly - Build successful ✅
Address all PR review comments ✅

Technical Details

The implementation now uses the official cosmos-sdk server flag constants to ensure consistency with the SDK's configuration system. Unknown pruning mode values are mapped to "metadata" mode, which provides a conservative middle-ground that prunes block data but preserves metadata.

The cosmos-sdk import is qualified as sdkserver throughout the server package to avoid name collisions with the local server package.

Original prompt

Problem Statement

Update PR #332 to:

Remove pruning key clearing in server/start.go and instead map the cosmos-sdk default pruning configuration keys to ev-node/pkg/config/PruningConfig

Currently, in server/start.go lines 727-736, there's a clearConflictingViperKeys function that clears pruning-related keys:
func clearConflictingViperKeys(v *viper.Viper) {
	conflictingKeys := []string{"pruning", "pruning-keep-recent", "pruning-interval"}
	for _, k := range conflictingKeys {
		val := v.Get(k)
		if _, isString := val.(string); isString {
			v.Set(k, map[string]interface{}{})
		}
	}
}
Replace this approach with proper mapping that converts cosmos-sdk pruning config keys to ev-node's PruningConfig format:

Cosmos SDK uses: pruning, pruning-keep-recent, pruning-interval

ev-node expects: evnode.pruning.pruning_mode, evnode.pruning.pruning_keep_recent, evnode.pruning.pruning_interval

The mapping should:

Convert cosmos-sdk pruning string values (like "default", "nothing", "everything", "custom") to ev-node's pruning_mode (one of: "disabled", "all", "metadata")

Map pruning-keep-recent to evnode.pruning.pruning_keep_recent

Map pruning-interval to evnode.pruning.pruning_interval

Handle the conversion properly in the clearConflictingViperKeys function (rename it to something like mapCosmosPruningToEvNode)

Refer to ev-node's PruningConfig structure:
type PruningConfig struct {
	Mode       string          `mapstructure:"pruning_mode"`
	KeepRecent uint64          `mapstructure:"pruning_keep_recent"`
	Interval   DurationWrapper `mapstructure:"pruning_interval"`
}
Valid modes: "disabled", "all", "metadata"

Remove sonic replaces from all Dockerfiles

Remove the lines that install/get the github.com/bytedance/sonic package:

In Dockerfile (line 28): Remove go get github.com/bytedance/sonic@v1.15.0 && \

In Dockerfile.cosmos-sdk (line 35): Remove go get github.com/bytedance/sonic@v1.15.0 && go mod tidy

In tests/integration/docker/Dockerfile.gm (line 39): Remove && go get github.com/bytedance/sonic@v1.15.0 \

Implementation Details

For the pruning config mapping:

Rename clearConflictingViperKeys to mapCosmosPruningToEvNode

Read the cosmos-sdk pruning config values

Convert them to ev-node format:

"default" → "all" (or appropriate mapping)

"nothing" → "disabled"

"everything" → "all"

"custom" → "all" or "metadata" (depending on context)

Set the converted values in viper with the ev-node key prefixes

For the dockerfile changes:

Simply remove the sonic installation lines

Ensure the remaining go mod operations work correctly

Expected Outcome

After this change:

The pruning configuration from cosmos-sdk's app.toml should be properly mapped to ev-node's configuration

Docker builds should no longer include the sonic dependency

The PR should be ready for review with these updates applied

This pull request was created from Copilot chat.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Rename clearConflictingViperKeys to mapCosmosPruningToEvNode - Map cosmos-sdk pruning keys to ev-node format with proper value conversion - Add comprehensive tests for pruning mapping function - Remove sonic installation from all Dockerfiles Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

- Simplify switch statement logic in mapCosmosPruningToEvNode - Add test case for verifying cosmos settings override existing evnode settings Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

julienrbrt · 2026-02-17T09:58:35Z

server/start.go

+	case "default", "everything", "custom":
+		evnodePruningMode = "all"
+	default:
+		// Unknown non-empty values default to "all", empty values remain empty


Unknown values default to disabled.

Fixed in 387da22. Unknown pruning values now default to "disabled" instead of "all".

julienrbrt · 2026-02-17T09:59:59Z

server/start.go

+		v.Set("evnode.pruning.pruning_keep_recent", cosmosKeepRecent)
+	}
+	if cosmosInterval != "" {
+		v.Set("evnode.pruning.pruning_interval", cosmosInterval)


Make sure we can set the interval like this. In ev-node intervals are time, while in the SDK I believe it is number of block. If that's the case, make sure to do nblock * blockTime

Fixed in 387da22. The interval is now properly converted from blocks to time duration by multiplying the block count by the block time (from evnode.node.block_time, defaulting to 1s if not set).

julienrbrt · 2026-02-17T10:01:19Z

server/start_test.go

+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			v := viper.New()
+			v.Set("pruning", tc.cosmosPruning)


Improve the test by using server DefaultConfig() and read it to viper, to make sure this works.

Fixed in 387da22. Added a new test TestMapCosmosPruningToEvNode_WithDefaultConfig that uses serverconfig.DefaultConfig() to test with realistic cosmos-sdk configuration values.

julienrbrt · 2026-02-17T10:25:03Z

@copilot check my comments

- Change unknown pruning values to default to "disabled" instead of "all" - Convert cosmos-sdk pruning-interval from blocks to time duration - Add evnode.node.block_time to tests and use DefaultConfig for realistic testing - Update all test expectations to match the block-to-duration conversion Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

julienrbrt · 2026-02-17T11:29:22Z

server/start.go

+		evnodePruningMode = "disabled"
+	case "default", "everything", "custom":
+		evnodePruningMode = "all"
+	default:


Make default case to do metadatas only @copilot

Fixed in 3608be4. The default case now maps unknown pruning values to "metadata" instead of "disabled".

julienrbrt · 2026-02-17T11:33:50Z

server/start.go

+func mapCosmosPruningToEvNode(v *viper.Viper) {
+	// Get cosmos-sdk pruning configuration
+	cosmosPruning := v.GetString("pruning")
+	cosmosKeepRecent := v.GetString("pruning-keep-recent")


Use the flags from the SDK package instead of directly putting them here (client/flags or server most likely)

Fixed in 3608be4. Now using cosmos-sdk server flag constants (sdkserver.FlagPruning, sdkserver.FlagPruningKeepRecent, sdkserver.FlagPruningInterval) instead of hardcoded string literals.

- Change default case to map unknown pruning values to "metadata" instead of "disabled" - Use cosmos-sdk server flag constants (FlagPruning, FlagPruningKeepRecent, FlagPruningInterval) instead of hardcoded strings - Update imports across server package to use qualified sdkserver import to avoid name collision - Update all tests to use the SDK flag constants - Update test expectations for unknown value mapping to metadata Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

* prunning * changed to batch delete * Map cosmos-sdk pruning config to ev-node format and remove sonic dependency (#345) * Initial plan * Implement pruning config mapping and remove sonic dependency - Rename clearConflictingViperKeys to mapCosmosPruningToEvNode - Map cosmos-sdk pruning keys to ev-node format with proper value conversion - Add comprehensive tests for pruning mapping function - Remove sonic installation from all Dockerfiles Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Fix comment clarity in mapCosmosPruningToEvNode Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Simplify logic and add test for override behavior - Simplify switch statement logic in mapCosmosPruningToEvNode - Add test case for verifying cosmos settings override existing evnode settings Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Remove redundant empty string case in switch statement Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Address PR review feedback on pruning mapping - Change unknown pruning values to default to "disabled" instead of "all" - Convert cosmos-sdk pruning-interval from blocks to time duration - Add evnode.node.block_time to tests and use DefaultConfig for realistic testing - Update all test expectations to match the block-to-duration conversion Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * Address PR review: use SDK flag constants and map unknown to metadata - Change default case to map unknown pruning values to "metadata" instead of "disabled" - Use cosmos-sdk server flag constants (FlagPruning, FlagPruningKeepRecent, FlagPruningInterval) instead of hardcoded strings - Update imports across server package to use qualified sdkserver import to avoid name collision - Update all tests to use the SDK flag constants - Update test expectations for unknown value mapping to metadata Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com> * fixes * updates --------- Co-authored-by: julienrbrt <julien@rbrt.fr> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

Initial plan

66e8ec2

Copilot AI assigned Copilot and julienrbrt Feb 17, 2026

Copilot started work on behalf of julienrbrt February 17, 2026 09:34 View session

Copilot AI and others added 4 commits February 17, 2026 09:41

Fix comment clarity in mapCosmosPruningToEvNode

fc948a3

Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

Simplify logic and add test for override behavior

eab9f87

- Simplify switch statement logic in mapCosmosPruningToEvNode - Add test case for verifying cosmos settings override existing evnode settings Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

Remove redundant empty string case in switch statement

dc18fa7

Co-authored-by: julienrbrt <29894366+julienrbrt@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove pruning key clearing and map to ev-node config~~ Map cosmos-sdk pruning config to ev-node format and remove sonic dependency Feb 17, 2026

Copilot AI requested a review from julienrbrt February 17, 2026 09:48

Copilot finished work on behalf of julienrbrt February 17, 2026 09:48

julienrbrt reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of julienrbrt February 17, 2026 10:25 View session

Copilot AI requested a review from julienrbrt February 17, 2026 10:32

Copilot finished work on behalf of julienrbrt February 17, 2026 10:32

julienrbrt reviewed Feb 17, 2026

View reviewed changes

Copilot started work on behalf of julienrbrt February 17, 2026 11:35 View session

Copilot AI requested a review from julienrbrt February 17, 2026 11:44

Copilot finished work on behalf of julienrbrt February 17, 2026 11:44

julienrbrt marked this pull request as ready for review February 17, 2026 11:56

julienrbrt requested a review from a team as a code owner February 17, 2026 11:56

julienrbrt merged commit 4d7ceb5 into pierrick/prunning Feb 17, 2026

julienrbrt deleted the copilot/remove-pruning-key-clearing branch February 17, 2026 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Map cosmos-sdk pruning config to ev-node format and remove sonic dependency#345

Map cosmos-sdk pruning config to ev-node format and remove sonic dependency#345
julienrbrt merged 7 commits intopierrick/prunningfrom
copilot/remove-pruning-key-clearing

Copilot AI commented Feb 17, 2026 •

edited

Loading

Uh oh!

julienrbrt Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

julienrbrt Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

julienrbrt Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

julienrbrt commented Feb 17, 2026

Uh oh!

julienrbrt Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

julienrbrt Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation Plan

1. Update pruning configuration mapping in server/start.go

2. Remove sonic dependency from Dockerfiles

3. Testing and Validation

Technical Details

Problem Statement

Implementation Details

Expected Outcome

Uh oh!

julienrbrt Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

julienrbrt Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

julienrbrt Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

julienrbrt commented Feb 17, 2026

Uh oh!

julienrbrt Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

julienrbrt Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 17, 2026 •

edited

Loading

1. Update pruning configuration mapping in `server/start.go`