fix(vscode): prefer the live dev sidecar over a stale bundle in dev mode#71
Merged
Conversation
`resolveSidecarPath` preferred the bundled `sidecar/server.js` whenever it existed, so in development (`--extensionDevelopmentPath`) a stale bundle left by an earlier `vscode:package` shadowed the live `packages/core/dist/server.js` — core edits silently didn't take effect, and a broken bundle (see the ESM-load fix) couldn't be worked around by rebuilding. Prefer the dev path when `context.extensionMode === ExtensionMode.Development` and it exists; a packaged VSIX has no dev path so it still uses the bundle (ADR-017).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
resolveSidecarPathreturned the bundledsidecar/server.jswhenever itexisted, falling back to the dev path only if absent. In development
(
task vscode:run→--extensionDevelopmentPath) this means a stalebundle from an earlier
vscode:packageshadows the livepackages/core/dist/server.js:around by rebuilding core.
This caused real confusion this session — a stale Jun-1 bundle ran
instead of the current build.
Fix
When
context.extensionMode === vscode.ExtensionMode.Developmentand thedev path exists, prefer it. A packaged VSIX has no dev path, so it still
uses the bundled sidecar (ADR-017) — production behaviour is unchanged.
Verification
clients/vscodetypecheck + eslint + prettier + build all green.