feat(core): configRead {kind,name} — complete the configList registry contract (T-401)#64
Merged
Conversation
Completes the configList contract (ADR-050) with its read sibling, mirroring
the commandList+commandRead pair (ADR-048). ConfigReadRequest {kind,name},
ConfigReadResponse {kind,name,source,body}, and a local-only ConfigSource
enum ('local'|'missing', no 'mcp'). Registers configRead in the Methods
registry and the hand-maintained codegen descriptors (67->69 Kotlin DTOs).
…401) ConfigHandler.read reads the artifact body off the same walk-once cache configList groups, so list and read can never disagree. Local-only: a node hit is source 'local', a miss is 'missing' with an empty body (no throw, mirrors commandRead). Matches the DISPLAY name (frontmatter name ?? slug) via a shared displayName helper so list/read key identically. Dispatcher route behind the existing requireConfig() gate. +15 core tests (read per-kind, kind disambiguation, display-name match, missing, fail-open, shared cache; sidecar live-wiring over a temp tree).
Council codex+gemini UNANIMOUS Q0-Q3=A (wire now / {kind,name} key /
local-only / mirror commandRead). No checkbox flip — the detail-pane render
stays an IDE surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the
configListagent-config registry contract (ADR-050) with its read sibling,configRead {kind, name}→{kind, name, source, body}. This mirrors thecommandList+commandReadPAIR (ADR-048) — the command council had explicitly required BOTH because a list whose items the IDE cannot open into a detail pane is "half a contract".configListwas exactly that half-contract for skills + rules + commands.How
ConfigReadRequest {kind,name},ConfigReadResponse {kind,name,source,body}, and a local-onlyConfigSourceenum ('local' | 'missing', nomcpmember, unlikeCommandSource). RegisteredconfigReadin the Methods registry + hand-maintained codegen descriptors (67 → 69 Kotlin DTOs).ConfigHandler.readreads the body straight off the same walk-once cacheconfigListgroups, so list and read can never disagree. Local-only by design: the body is already parsed onto every walked node for all three kinds; MCP hasskill_read/command_readbut norule_read, so an MCP-first path would be asymmetric. A miss issource: 'missing'with an empty body (no throw, mirrorscommandRead). Matching is on the display name (frontmattername?? slug) via a shareddisplayNamehelper, so list/read key identically. Dispatcher route behind the existingrequireConfig()gate.Council
codex-cli 0.134.0 + gemini-cli 0.41.2, run serially. UNANIMOUS Q0–Q3 = A: wire now (complete the contract) /
{kind,name}key (names collide across kinds) / local-only / mirrorcommandRead. Q4 → full body uncapped (consistency withcommandRead). Q5 traps satisfied by design (shared walk cache → no disagreement; in-memory match → no path traversal).Verification
task ciexit 0 — lint, format, build, typecheck, test (core 1147 pass / 1 skip, +15).task jetbrains:checkBUILD SUCCESSFUL (the +2 Kotlin DTOs compile).See ADR-052.