Battery Hold Charge: ui state; api docs#30628
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
batteryChargeHoldstate and passing it asholdiniconPropsmakes the meaning of theholdflag ambiguous (discharge vs. charge hold); consider renaming the prop or wiring bothbatteryHoldandbatteryChargeHoldexplicitly to better reflect their semantics in the icon component. - Both
batteryChargeLabelandbatteryDischargeLabelnow build translation keys with string interpolation (battery...ChargeHold/DischargeHold); consider centralizing this mapping in a small helper or enum-to-key function to reduce duplication and avoid subtle key mismatches as more modes are added.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `batteryChargeHold` state and passing it as `hold` in `iconProps` makes the meaning of the `hold` flag ambiguous (discharge vs. charge hold); consider renaming the prop or wiring both `batteryHold` and `batteryChargeHold` explicitly to better reflect their semantics in the icon component.
- Both `batteryChargeLabel` and `batteryDischargeLabel` now build translation keys with string interpolation (`battery...ChargeHold` / `DischargeHold`); consider centralizing this mapping in a small helper or enum-to-key function to reduce duplication and avoid subtle key mismatches as more modes are added.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api docs and ui communication for new
hold chargestate introduced in #27906