Support unlimited length for null *print-length*

[Affonso-Gui]

Solves #365 and is cl-compatible.

According to CLHS

print-length controls how many elements at a given level are printed. If it is false, there is no limit to the number of components printed.

This PR commits do:

1. Support unlimited printing when print-length is nil
2. Fix print-length bug in vector printing, that was preventing for limit to be reached

1.eus$ (setq *print-length* 2)
2
2.eus$ (vector 1 2 3)
#(1 2 3)

3. Do not put spaces after the ...; do not print first element of lists when print-level is set to 0.

Was also going to update for unlimited *print-level* as well, but the printer starts to segfault before the max value 65536 is reached, so am leaving that untouched for now.

[k-okada]

Nice! Can you create test code for this? 2019年3月28日(木) 19:00 Affonso, Guilherme <notifications@github.com>:

Solves #365 <#365> and is cl-compatible. According to CLHS *print-length* controls how many elements at a given level are printed. If it is false, there is no limit to the number of components printed. This PR commits do: 1. Support unlimited printing when *print-length* is nil 2. Fix *print-length* bug in vector printing, that was preventing for limit to be reached 1.eus$ (setq *print-length* 2) 2 2.eus$ (vector 1 2 3) #(1 2 3) 1. Do not put spaces after the ...; do not print first element of lists when *print-level* is set to 0. Was also going to update for unlimited *print-level* as well, but the printer starts to segfault before the max value 65536 is reached, so am leaving that untouched for now. ------------------------------ You can view, comment on, or merge this pull request online at: #368 Commit Summary - Support unlimited *print-length* - Fix *print-length* on print-vector - Unify *print-length* formatting File Changes - *M* lisp/c/printer.c <https://github.com/euslisp/EusLisp/pull/368/files#diff-0> (54) Patch Links: - https://github.com/euslisp/EusLisp/pull/368.patch - https://github.com/euslisp/EusLisp/pull/368.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#368>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeG3OFNGMyQRuWir9R0NwVCuTgMF_A2ks5vbJK6gaJpZM4cPvGd> .

-- -- ◉ Kei Okada

[Affonso-Gui]

@k-okada Added ansi-test based test code

[Affonso-Gui]

Updated branch

[k-okada]

Thank you for contributing EusLisp documentation

Please check latest documents before merging

PDF version of English manual: manual.pdf
PDF version of Japanese jmanual: jmanual.pdf
HTML version of English manual: manual.html
HTML version of Japanese manual: jmanual.html
Sphinx (ReST) version of English manual: manual.rst

[k-okada]

Thank you for contributing EusLisp documentation

Please check latest documents before merging

PDF version of English manual: manual.pdf
PDF version of Japanese jmanual: jmanual.pdf
HTML version of English manual: manual.html
HTML version of Japanese manual: jmanual.html
Sphinx (ReST) version of English manual: manual.rst

[k-okada]

can we port this feature to master branch?

[k-okada]

is this ci-compatible/ChangeExistingFeature?
I thought this changes fixed length of print-length to unlimited length. so this is Extend existing feature.

[Affonso-Gui]

@k-okada

can we port this feature to master branch?

Should I make the needed changes and re-target this PR to master branch?

is this ci-compatible/ChangeExistingFeature?

It is cl-compatible, but I am not sure how it should be classified. Depending on how one arguments it can be said that it changes/extends existing features, add new features or fix bugs.