Repository navigation
Conversation
yunwei37
left a comment
There was a problem hiding this comment.
Reviewed at f3ecb12.
The change is exactly the reported defect and nothing else: one line of
docs/tutorials/24-hide/README.zh.md where the sentence was split across a
paragraph boundary.
-最后打
-
-印相应的消息。
+最后打印相应的消息。Reproduced before fixing, on the built site — the deployed HTML at
https://eunomia.dev/zh/tutorials/24-hide/ contains
…最后打</p><p>印相应的消息。
which is the screenshot in the issue, so this was the page's fault and not a
rendering artifact.
Kept the surrounding structure: the blank line that closed the paragraph is
still there, so the ```c fence that follows stays on its own block and the
code sample is unaffected. Line 364 is now one sentence and the next line is
still the empty line before the fence.
Confirmed this copy was the only one that drifted: diffing all 65 shared
README.zh.md files between bpf-developer-tutorial/src/ and
docs/tutorials/ found no other differences, so the upstream tutorial repo does
not need the same fix.
Ready for a maintainer's merge.
AI-generated response; a maintainer will review and follow up later
f3ecb12 to
9a0ca8a
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Reviewed at 9a0ca8a.
The substantive change is one paragraph in docs/tutorials/24-hide/README.zh.md: the sentence 最后打 / blank line / 印相应的消息。 is rejoined into 最后打\n\n印相应的消息。 → 最后打印相应的消息。, removing a stray blank line that was splitting a CJK word across two paragraphs. At this head line 364 is the single rejoined paragraph and the following blank line plus ```c fence are intact, so the rendered page no longer shows a one-word orphan paragraph. I scanned the rest of the file for the same pattern and found no other short CJK paragraph outside a code fence.
Worth being explicit about scope: the PR shows 16 files and 13 commits since the previous reviewed head (f3ecb12), but only the last commit (9a0ca8a1, "rejoin the split 打印 in 24-hide") touches this file. The remaining commits are publisher/skills/data-brief changes carried along by the branch — they are not part of this fix and are presumably going to be dropped or landed separately.
Checks at this head: deploy-static-app and GitGuardian green; sync-external-docs skipped, as it is on every PR in this repo, so it carries no signal. No build or route change, so nothing else to verify on the site side.
Verdict: mergeable as-is.
AI patrol review
3b28cd7 to
96c6ecf
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Reviewed head 96c6ecf95a: the previous review point (9a0ca8a194) moved onto today's main. The branch's own content is unchanged.
Evidence: for every path this pull request changes (1 file), the git blob at this head equals the blob at 9a0ca8a1. The apparent line churn against main comes from files main moved on, not from this branch.
So the earlier review of the change itself still stands, and this head is no longer behind its base. Merge readiness is unchanged: it waits on a maintainer's decision.
AI patrol review
|
Verdict: ready to merge Head Merge is the maintainer's to make: eunomia.dev is not in the small-repository group, so the patrol does not merge it. AI patrol review |
yunwei37
left a comment
There was a problem hiding this comment.
Verdict: ready to merge
The review above stands: this head's content is blob-identical to the previously reviewed revision, so only the rebase onto today's main moved. Checks green, mergeable, level with the base.
AI patrol review
96c6ecf to
560697b
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Verdict: ready to merge once CI is green
Reviewed head 560697b2. The only changed file, docs/tutorials/24-hide/README.zh.md, is blob-identical to the previously reviewed revision (96c6ecf9); merge base unchanged at f8a2cce8. The commits above the change are shared main history.
The change remains one paragraph: the split 打印 in the 24-hide Chinese tutorial is rejoined, and no code, path, command or output in the tutorial moves.
Checks on this head: GitGuardian Security Checks success, deploy-static-app queued. The verdict turns to merge-ready when that job reports green.
AI patrol review
The sentence at the end of the handle_event paragraph was broken across a paragraph boundary, so the rendered page showed 最后打 印相应的消息。 The source now reads 最后打印相应的消息。 as one sentence. Reported in bpf-developer-tutorial#232.
560697b to
69deae0
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Verdict: ready to merge once CI is green
Reviewed at head 69deae04, which is the previously reviewed 560697b2 moved onto today's base. Nothing in the change itself moved: for the range merge-base(main, head)..head, git patch-id --stable is identical before and after, and the changed file list with its line counts is unchanged. The earlier review (5912545022) therefore stands as written, and so does its verdict.
The rebase re-queued this head's checks, so the previous head's green results do not carry over; read the new run, not the old one. Merge stays with a maintainer.
AI patrol review
|
Verdict: ready to merge This is the verdict for head Merge is the maintainer's to make: eunomia.dev is not in the small-repository group, so the patrol does not merge it. AI patrol review |
Summary
The
handle_eventparagraph in the Chinese 24-hide tutorial was broken across aparagraph boundary, splitting the word
打印:which renders as two paragraphs, ending one on
最后打. Reported ineunomia-bpf/bpf-developer-tutorial#232, where the screenshot shows exactly that
break on https://eunomia.dev/zh/tutorials/24-hide/.
Change
Rejoin into one sentence:
Verification
Confirmed against the live page first — the rendered HTML contains
which is the reported symptom, and the source at
docs/tutorials/24-hide/README.zh.md:364had the same split. After the change theline reads
…最后打印相应的消息。and the following paragraph is the empty linebefore the
\``c` fence, so the fence stays on its own block.The upstream tutorial repo (
bpf-developer-tutorial/src/24-hide/README.zh.md)already has the joined sentence, so only this copy was affected.