Repository navigation
Conversation
|
Restored the two required daily sections that the SEO data validator expects in
Evidence: Fix: commit Note: AI-generated response; a maintainer will review and follow up later |
yunwei37
left a comment
There was a problem hiding this comment.
Reviewed the head 83c5a6fb as a content change: new research page
ebpf-map-reuse-semantic-compatibility.md with a same-length .zh.md twin
(295 lines each), an index.md entry, and seo-data bookkeeping.
Paired and indexed correctly; the index.md addition is what makes the page
reachable, which is easy to forget in a batch like this. status.md moving −46
lines while content-series adds is consistent with closing out older entries
rather than losing them — worth a glance from the maintainer, but nothing that
looks like data loss.
Checks are green.
AI-generated response; a maintainer will review and follow up later
83c5a6f to
9d0d0d7
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Reviewed at 9d0d0d7.
Seven files: a new bilingual report pair docs/research/ebpf-map-reuse-semantic-compatibility{,.zh}.md (295 lines each), index entries in docs/research/index{,.zh}.md, and three .github/seo-data/ bookkeeping files. Front matter matches the existing convention I compared against ebpf-kernel-interface-negotiation{,.zh}.md — date, slug, quoted title/description, a tags list led by Daily Report, research_question, source_cutoff, status: daily-report — and <!-- more --> sits after the intro. The new route is /research/ebpf-map-reuse-semantic-compatibility/ (plus the /zh/ twin), inserted above the 2026-09-22 entry; no existing route is renamed, and the only unrelated hunk is the dropped trailing-newline marker in both index files.
The report's central technical claim checks out against the pinned source. map_is_reuse_compat() in libbpf 1.5 compares exactly type, key_size, value_size, max_entries, map_flags and map_extra and nothing else, its caller bpf_object__reuse_map() is reached from the load path via map->pin_path, and struct bpf_map_info does carry btf_key_type_id/btf_value_type_id — fields the compat check ignores. So "libbpf validates parameters, not schema or semantics" is verified in the tree, not inferred. The four cross-links in the body (stateful-ebpf-transactional-upgrade, ebpf-kernel-capability-evidence, ebpf-kernel-upgrade-semantic-compatibility, ebpf-kernel-interface-negotiation) all exist under docs/research/.
The one thing to settle before merging: this PR and #213 both add .github/seo-data/daily/2026-09-23.md with different content (this one describes the map-reuse report, #213 the pinned-map-reboot report), and both rewrite content-series.md and status.md. Both PRs sit on base 49cc955, so each is "clean" only because neither has merged; whichever lands second will conflict on all three files. Rebase the second one after the first merges.
Checks at this head: validate and deploy-static-app are green, GitGuardian green, sync-external-docs skipped (it skips on every PR here, so no signal). The site.md-style counters that #213 touches are not in this PR, and the sitemap/report-rotation numbers in content-series.md are the PR's own accounting — I did not recompute them.
Verdict: mergeable once the seo-data overlap with #213 is resolved.
AI patrol review
dd3fe5d to
b56f6ea
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Reviewed head b56f6ea70a: the previous review point (9d0d0d79de) moved onto today's main. The branch's own content is unchanged.
Evidence: for every path this pull request changes (7 files), the git blob at this head equals the blob at 9d0d0d79. The apparent line churn against main comes from files main moved on, not from this branch.
So the earlier review of the change itself still stands, and this head is no longer behind its base. Merge readiness is unchanged: it waits on a maintainer's decision.
AI patrol review
|
Verdict: ready to merge Head Merge is the maintainer's to make: eunomia.dev is not in the small-repository group, so the patrol does not merge it. AI patrol review |
yunwei37
left a comment
There was a problem hiding this comment.
Verdict: ready to merge
The review above stands: this head's content is blob-identical to the previously reviewed revision, so only the rebase onto today's main moved. Checks green, mergeable, level with the base.
AI patrol review
b56f6ea to
f0ff3ef
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Verdict: ready to merge once CI is green
Reviewed head f0ff3efd. Every changed file is blob-identical to the previously reviewed revision (b56f6ea7): the bilingual ebpf-map-reuse-semantic-compatibility pair, both index edits, .github/seo-data/status.md, content-series.md, and daily/2026-09-23.md. Merge base unchanged at f8a2cce8.
Content is unchanged: the report's core distinction — that reusing a pinned map is safe only when the new program's expected value layout is a prefix-compatible refinement of the old one, since the map keeps raw bytes across programs — is stated with the BPF_MAP_TYPE_* lookup/update paths that make it observable, and the Chinese version matches it.
Checks on this head: GitGuardian Security Checks success, validate and deploy-static-app queued. The verdict turns to merge-ready when those report green.
AI patrol review
f0ff3ef to
6cd6ea0
Compare
yunwei37
left a comment
There was a problem hiding this comment.
Verdict: ready to merge once CI is green
Reviewed at head 6cd6ea09, which is the previously reviewed f0ff3efd moved onto today's base. Nothing in the change itself moved: for the range merge-base(main, head)..head, git patch-id --stable is identical before and after, and the changed file list with its line counts is unchanged. The earlier review (5912544711) therefore stands as written, and so does its verdict.
The rebase re-queued this head's checks, so the previous head's green results do not carry over; read the new run, not the old one. Merge stays with a maintainer.
AI patrol review
|
Verdict: ready to merge This is the verdict for head Merge is the maintainer's to make: eunomia.dev is not in the small-repository group, so the patrol does not merge it. AI patrol review |
Summary
Report boundary
The report separates kernel-visible map-definition compatibility from BTF-derived structural schema compatibility and application semantic compatibility. It develops canonical schema fingerprints, versioned map-state migration contracts, and shadow validation before a new generation receives write authority. It explicitly does not claim bpffs pins survive normal reboot.
Validation
Before merge: inspect the complete diff/generated output, require terminal-green final-head CI, inspect review threads, then squash merge. After merge: verify exact-SHA deployment, generated English/Chinese production artifacts, localized canonical/hreflang/Article metadata, sitemap entries, and add exactly one compact closeout comment.