Fix for UnscentedKalmannFilter#195
Open
condor-cp wants to merge 2 commits into
Open
Conversation
Author
|
Should I do this pull request in the v3.0.3-devel branch ? |
markusgft
approved these changes
Jul 5, 2021
Member
|
re-running unit tests. |
Author
|
I just rebased my fork on the upstream v3.0.2 since the PR was not applied. I also added a commit to make hpipm mode configurable. I thought the current PR would have been unaffected but I see it mirrored the changes I made in my forked branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to run the UnscentedKalmannFilter without these two modifications :
I guess the problems remained undetected because in the test built for Kalmann Filtering, STATE_DIM == OUTPUT_DIM == 2