ENG-2699: CSS fixes for TCF embedded consent in mobile SDK#7513
ENG-2699: CSS fixes for TCF embedded consent in mobile SDK#7513thabofletcher wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Greptile SummaryImplements CSS fixes for TCF embedded consent in mobile SDK WebViews to support both dismissable and non-dismissable Key changes:
Critical issue: The changelog description only mentions "margin reset" but doesn't capture the full scope of these CSS changes, which could mislead future developers reviewing the change history. Confidence Score: 3/5
Important Files Changed
Last reviewed commit: 9d22e6a |
| @@ -0,0 +1,4 @@ | |||
| type: Fixed | |||
| description: Added margin reset to embedded consent page body for proper mobile SDK WebView layout | |||
There was a problem hiding this comment.
changelog doesn't capture full scope of changes - it only mentions margin reset but PR includes TCF overlay flexbox layout, sticky footer, responsive breakpoints (768px), close button hiding, and modal overflow fixes
| description: Added margin reset to embedded consent page body for proper mobile SDK WebView layout | |
| description: CSS fixes for TCF embedded consent in mobile SDK WebViews supporting dismissable and non-dismissable banner_and_modal experiences across phone and tablet breakpoints |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Ticket ENG-2699
Description Of Changes
CSS fixes for TCF embedded consent in mobile SDK WebViews to support both dismissable and non-dismissable
banner_and_modalexperiences.Code Changes
clients/privacy-center/public/embedded-consent.html:dismissablesetting.Steps to Confirm
embedded-consent.html?geolocation=de&property_id=FDS-C33DQM(any TCF region, and your property ID instead)dismissable=trueanddismissable=falseexperience configs (if possible, reporting client uses dismissable=true so that is the more critical testPre-Merge Checklist
CHANGELOG.mdupdated