Skip to content

ENG-2732: Change description span to div#7502

Draft
tvandort wants to merge 2 commits intomainfrom
ENG-2732
Draft

ENG-2732: Change description span to div#7502
tvandort wants to merge 2 commits intomainfrom
ENG-2732

Conversation

@tvandort
Copy link
Contributor

@tvandort tvandort commented Feb 26, 2026

Ticket ENG-2732

Description Of Changes

Change experience description to use a div instead of a span because span doesn't support all tags as descendants. Notably a client reporting that p tags were being mangled.

Code Changes

  • Change p to div

Steps to Confirm

  1. Allow HTML descriptions
  2. Configure an experience description that contains a p tag
  3. Load that experience on a page somewhere and ensure that p tag isn't mangled

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 26, 2026 5:28pm
fides-privacy-center Ignored Ignored Feb 26, 2026 5:28pm

Request Review

@tvandort
Copy link
Contributor Author

I am admittedly a little worried about this change. The good thing is that span doesn't have default styling or any semantics, much like div. There is a difference in which element is a block or not by default which might get me into trouble here. I'd appreciate some help thinking what could go wrong as a result of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant