ENG-2213: Reorganize services, connectors, and shared modules#7453
Draft
galvana wants to merge 6 commits intocli-and-core-cleanupfrom
Draft
ENG-2213: Reorganize services, connectors, and shared modules#7453galvana wants to merge 6 commits intocli-and-core-cleanupfrom
galvana wants to merge 6 commits intocli-and-core-cleanupfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
galvana
force-pushed
the
service-and-connector-cleanup
branch
from
ca3c197 to
01d2c46
Compare
galvana
changed the title
galvana
force-pushed
the
service-and-connector-cleanup
branch
from
df11e5a to
315cace
Compare
Move connectors to root-level with per-connector subdirectories, co-locate query configs, flatten base/ into connectors root, add shared/ for cross-connector query configs, and move root-level services into their own subdirectories. Co-authored-by: Cursor <cursoragent@cursor.com>
Bad merge artifact from rebase — the import was added during conflict resolution but is never used in the test file. Co-authored-by: Cursor <cursoragent@cursor.com>
- Remove stray fides.common.constants imports from urn_registry.py - Inline REQUEST_TASK_CALLBACK, CONNECTION_TYPES, CONNECTION_BY_KEY, SAAS_CONFIG - Update test imports for moved modules (masking, connectors, okta) - Remove duplicate urn_registry imports from test files Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
galvana
force-pushed
the
cli-and-core-cleanup
branch
from
8572883 to
551e7d3
Compare
galvana
force-pushed
the
service-and-connector-cleanup
branch
from
4415849 to
001c4ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the module structure cleanup from
cli-and-core-cleanup. This PR reorganizes three major areas:Connectors — Moves all connectors from
fides.api.service.connectors.*to a root-levelfides.connectorspackage with per-connector subdirectories (e.g.,fides.connectors.bigquery,fides.connectors.saas,fides.connectors.mongodb). Co-locates query configs with their connectors, moves authentication/pagination/post-processor strategies underfides.connectors.saas.strategies, and addsfides.connectors.sharedfor cross-connector query configs.Services — Flattens
fides.api.service.*intofides.service.*:messaging/→fides.service.messagingstorage/→fides.service.storagemasking/→fides.service.privacy_request.maskingasync_dsr/→fides.service.privacy_request.async_dsrdsr_package/,email_batch_service,request_runner_service, etc. →fides.service.privacy_requestattachment_service→fides.service.attachmentevent_audit_service→fides.service.event_auditconnector_registry_service→fides.service.connectionfides.api.v1.endpoints.drpstrategy.py→fides.common.strategyShared modules — Decouples lower layers from
fides.api.v1:urn_registry.py→fides.common.urn_registry(all URL path constants, includingV1_URL_PREFIX)fides.common.credentials(moved fromcli.core.utilsto breakconfig → clicircular import)get_dbgenerator →fides.common.session.session_management(canonical session location;api.depsre-exports it)oauth/utils.pyimports session management fromcommon.sessioninstead ofapi.depsTest plan
nox -s static_checkspasses (ruff + mypy)nox -s collect_tests— 7851 tests collected