Improve PSP support - #553
Open
Schamper wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve PSP support by adding:
Depends on Decompollaborate/spimdisasm#209, so I've left 2 TODO's for pending version bumps to make this PR work.
One thing specifically needed for SNC is the added
include_asm_macro_style. The default macro always sets.set reorderafter "returning" from the include, but assembly generated by the SN compiler already sets.set noreorderat the top level, so this was causing issues when trying to match assembly output. The addedinclude_asm_macro_styledoesn't change thenoreorder/reorderflag.Adding the compiler configuration is mostly for completion sake.