Better VC options in entrypoint, including Graffiti#2688
Draft
yorickdowne wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
Needs to be rebased after #2686 is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
For "all-in-1" clients, only configure VC options when the embedded VC is in use. This makes it easier for users to understand parameters when they
ps auxww | grep <client-executable>Refactor Graffiti handling. Because spaces in Graffiti have to be preserved, Graffiti was special-cased before, with two separate
execlines. Use an array for parameter expansion instead, so${GRAFFITI}with spaces remains preserved while also handling spaces between parameters and handling no graffiti parameter when using default graffiti.