Fixing redundancy in the airbyte_to_flow step in GitHub Actions #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Please take a look and let me know your thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Refactor
airbyte_to_flowjob to use general conditional (DRY)Description
Summary
This PR refactors the
airbyte_to_flowstep in the GitHub Actions pipeline by removing repeated conditional checks.Details
To follow the DRY principle, I moved this into a general job-level conditional instead of repeating it at each step.
Benefits
Cleaner and more maintainable workflow file.
Reduces redundancy and potential errors from duplicated conditions.