Skip to content

Conversation

@gabsuren
Copy link
Collaborator

1.6.1
Bug Fixes

  • Fix race conditions, memory leak, and data loss (23ca97d)
    • Add state check in abort_connection to prevent double-close
    • Fix memory leak: free errormsg_buffer on disconnect
    • Reset connection state on reconnect to prevent stale data
    • Implement lock ordering for separate TX lock mode
    • Read buffered data immediately after connection to prevent data loss
    • Added sdkconfig.ci.tx_lock config

Checklist

Before submitting a Pull Request, please ensure the following:

  • [ *] 🚨 This PR does not introduce breaking changes.
  • [ *] All CI checks (GH Actions) pass.
  • [ *] Documentation is updated as needed.
  • [ *] Tests are updated or added as necessary.
  • [ *] Code is well-commented, especially in complex areas.
  • [ *] Git history is clean — commits are squashed to the minimum necessary.

1.6.1
Bug Fixes
- Fix race conditions, memory leak, and data loss (23ca97d)
    - Add state check in abort_connection to prevent double-close
    - Fix memory leak: free errormsg_buffer on disconnect
    - Reset connection state on reconnect to prevent stale data
    - Implement lock ordering for separate TX lock mode
    - Read buffered data immediately after connection to prevent data loss
    - Added sdkconfig.ci.tx_lock config
@gabsuren gabsuren self-assigned this Dec 29, 2025
@cursor
Copy link

cursor bot commented Dec 29, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 20.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor formatting issue -- feel free to ignore, but would like to fix it somehow.
Also, I recall that each line did contain a reference to the original commit?

Comment on lines +8 to +13
- Add state check in abort_connection to prevent double-close
- Fix memory leak: free errormsg_buffer on disconnect
- Reset connection state on reconnect to prevent stale data
- Implement lock ordering for separate TX lock mode
- Read buffered data immediately after connection to prevent data loss
- Added sdkconfig.ci.tx_lock config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Not sure why the formatting is off here? Do we have an issue with the generator script?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-cermak thanks for pointing this out.
Actually the changes were part of a single large commit 23ca97d (I probably should have split it into separate commits for each change).
As a result, the generated changelog looks like this:

1.6.1
    Bug Fixes
    - Fix race conditions, memory leaks, and data loss (23ca97d5)
        - Add state check in abort_connection to prevent double-close
        - Fix memory leak: free errormsg_buffer on disconnect
        - Reset connection state on reconnect to prevent stale data
        - Implement lock ordering for separate TX lock mode
        - Read buffered data immediately after connection to prevent data loss
        - Add sdkconfig.ci.tx_lock config

Another option to keep them in one line separated by - and appending the commit SHA at the end.
What do you think would be the preferred approach here?

@gabsuren gabsuren merged commit b7f3de5 into espressif:master Jan 8, 2026
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants