Skip to content

Correct archive filename (fix #9) - #10

Open
jcassette wants to merge 1 commit into
espressif:mainfrom
jcassette:archive_name
Open

Correct archive filename (fix #9)#10
jcassette wants to merge 1 commit into
espressif:mainfrom
jcassette:archive_name

Conversation

@jcassette

@jcassette jcassette commented Jun 3, 2022

Copy link
Copy Markdown

Fix #9

@vikramdattu

Copy link
Copy Markdown
Contributor

@jcassette thanks for spotting and fixing this. We will review it internally and take the change.

@vikramdattu

Copy link
Copy Markdown
Contributor

Hi @jcassette, if you set PROJECT_VER in your top level CMakeList.txt, that is picked up and you won't fall to git describe path which you are.
We recommend you setting PROJECT_VER in project CMakeList.txt.

Example:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archive filename is incorrect

2 participants