Open
Conversation
Owner
|
Hi @dwhenry! Would it be OK to apply the changes to lib/json-diff/diff.rb? In terms of versioning, it feels awkward to have both a v2 and a version 0.5.0-dwhenry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR duplicates the existing code then converts it from a module-based into a Class-based approach. The main reason for this to add extra functionality on the addition check (i.e. I want to be able to programmatically decide when to include additional based on the type of parent object and the current path)
This type of change was just not possible with the previous code implementation. I have reused the existing methods and avoided changing the interface so this can be used as a drop-in replacement for the previous code. The advantage of this approach is that rebasing changes from the master branch is do as should pick up any changes which are not to the core diffing method automatically.