Eliminate most 'deprecated declarations' warnings - #122
Open
jkeenan wants to merge 2 commits into
Open
Conversation
This change reduced the count of Wdeprecated-declaration build-time warnings (gcc-13 Linux) from 9 to 3. DDG search: XKeycodeToKeysym is deprecated
The change in this macro is documented in pod/perl5380delta.pod This change reduced the count of Wdeprecated-declaration build-time warnings (gcc-13 Linux) from 3 to 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I build Tk-804.036 against a Perl executable built on Linux and compiled with
gcc-13(currently the most recent version ofgccagainst which Tk'smakewill complete), I get the following count of build-time warnings:The patches in this pull request, when applied will reduce the number of
Wdeprecated-declarationswarnings from 9 to 1.For changes in tkUnixKey.c, consult DDG search for "XKeycodeToKeysym is deprecated".
For changes in Event/Event.xs, see
perldoc perl5380delta.The one remaining
Wdeprecated-declarationsbuild-time warning appears duringmakelike this:And here's the relevant source code in pTk/Xlib.t:
A simple search-and-replace,
XKeycodeToKeysym->XkbKeycodeToKeysym, did not compile, so I left this instance alone.