Skip to content

fix(desktop): streamline task controls and toolbar / 精简任务控制与顶栏 - #8392

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/desktop-task-monitor-toolbar
Aug 11, 2026
Merged

fix(desktop): streamline task controls and toolbar / 精简任务控制与顶栏#8392
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/desktop-task-monitor-toolbar

Conversation

@SivanCola

@SivanCola SivanCola commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the duplicate Stop/Cancel task controls with one accessible Stop flow. The confirmation replaces the action row, moves focus to the destructive action, restores focus on Escape, and dismisses itself if polling observes a terminal task.
  • Localize task lifecycle/runtime presentation and the Session summary control in English, Simplified Chinese, and Traditional Chinese.
  • Remove redundant topic-bar shortcuts and command-palette buttons while preserving Cmd/Ctrl+K and Settings access, then place Session summary immediately before the right-edge workspace toggle.
  • Keep the backend CancelTask APIs and CLI behavior intact; Stop and Cancel already route to the same terminal transition.

Issues

Verification

  • pnpm build
  • pnpm test
  • pnpm test:task-monitor (22 panel tests + 3 navigation tests)
  • pnpm exec tsx src/__tests__/app-chrome-tabs.test.ts (128 tests)
  • pnpm exec tsx src/__tests__/topicbar-controls.test.ts (2 contracts)
  • go run ./tools/repolint
  • Browser verification at the local desktop frontend: toolbar order, localized Session summary dialog, Cmd/Ctrl+K fallback, Stop confirmation focus/Escape behavior, and no console errors.
  • Source-level platform coverage verifies the shared topic bar and task monitor paths used by macOS, Windows, and Linux across Classic, Workbench, and Creation styles.

Documentation impact

Documentation-impact: none - this is a self-explanatory desktop UI simplification with localized labels and no public API or configuration change.

Cache impact

Cache-impact: none - frontend presentation and interaction only; no cache keys, providers, model catalogs, or request payload schemas change.
Cache-guard: provider-visible prompts and tool schemas are untouched; full frontend build, bundle budgets, and test suite pass.
System-prompt-review: N/A

@SivanCola
SivanCola requested a review from esengine as a code owner August 11, 2026 10:30
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Aug 11, 2026
Problem:
The task monitor exposed duplicate stop and cancel actions with a cramped confirmation flow, while the topic toolbar repeated command and shortcut entry points and placed the workspace control inconsistently.

Root cause:
The desktop UI surfaced backend control aliases as separate primary actions and accumulated utility controls without a clear priority order or complete localization.

Fix:
Merge active-task termination into a single accessible stop flow, localize task state and session-summary labels, remove redundant toolbar entry points, and place session summary before the workspace toggle. Keep the underlying cancel APIs and keyboard/settings access paths intact.

Verification:
- pnpm exec tsx src/components/TaskMonitorPanel.test.tsx
- pnpm exec tsx src/__tests__/app-chrome-tabs.test.ts
- pnpm check:css
- pnpm typecheck
- Browser verification at 127.0.0.1:5174
@SivanCola
SivanCola force-pushed the fix/desktop-task-monitor-toolbar branch from 90f83ee to f57e1bc Compare August 11, 2026 10:33
@SivanCola
SivanCola merged commit 6d26292 into esengine:main-v2 Aug 11, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant