Skip to content
This repository was archived by the owner on Oct 16, 2025. It is now read-only.

Issue/gc issue#419

Open
chihung93 wants to merge 2 commits into
esafirm:mainfrom
chihung93:issue/GC_Issue
Open

Issue/gc issue#419
chihung93 wants to merge 2 commits into
esafirm:mainfrom
chihung93:issue/GC_Issue

Conversation

@chihung93

Copy link
Copy Markdown
Contributor

I have added the size of the image which depends on the orientation. Please help me to review and merge it

Issue:

#368

@chihung93 chihung93 mentioned this pull request Oct 24, 2022
@esafirm

esafirm commented Oct 24, 2022

Copy link
Copy Markdown
Owner

Hi @chihung93 thanks for the PR, although I'm pretty sure this is already handled by Glide internally, but you can tell me if I'm wrong on this. A before-after video would be great 😃

Also, we have Custom Component API which makes this change less wanted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants