Repository navigation
Conversation
PR #22395 (typescript 6.0.3 -> 7.0.2) was closed because TypeScript 7 removed `baseUrl` (TS5102), which @docusaurus/tsconfig still sets as of 3.10.2. An inherited compilerOption cannot be unset by the extending config, and docs/site/tsconfig.json's `ignoreDeprecations: "6.0"` only silences TS 6's TS5101 deprecation — TS 7 rejects the option itself. Since docs-site-build.yml gates `npm run typecheck`, a TS 7 bump turns docs CI red. Closing a Dependabot PR only suppresses that exact version, so 7.0.3 and every later 7.x would re-propose it. Encode the decision instead. Minor and patch TypeScript updates keep flowing. Taking TS 7 later means inlining @docusaurus/tsconfig's options minus baseUrl (deleting our local baseUrl alone would just inherit theirs). That fix is already proven in erigontech/cocoon#36 and erigontech/zilkworm-docs#13 if we want it here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by #22764, which removes the need for this deferral: it drops If we ever want to pin back to TypeScript 6, this rule is the way to do it — the rationale is preserved in the commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #22395 (
typescript6.0.3 → 7.0.2) was closed because TypeScript 7 removedbaseUrl(TS5102), which@docusaurus/tsconfigstill sets as of 3.10.2:An inherited
compilerOptioncannot be unset by the extending config, anddocs/site/tsconfig.json's"ignoreDeprecations": "6.0"only silences TS 6's TS5101 deprecation — TS 7 rejects the option itself. Sincedocs-site-build.ymlgatesnpm run typecheck, a TS 7 bump turns docs CI red.What
Closing a Dependabot PR suppresses only that exact version, so 7.0.3 and every later 7.x would re-propose it. This encodes the decision instead. Minor and patch TypeScript updates keep flowing.
No behaviour change — Dependabot config only.
If we want TS 7 later
It requires inlining
@docusaurus/tsconfig's options minusbaseUrl. Note that deleting our localbaseUrl: "."alone would not work — it would just inherit theirs. That fix is already proven in erigontech/cocoon#36 and erigontech/zilkworm-docs#13.Aside: our local
baseUrl: "."is also why@site/*resolves correctly here. In both sibling repos the option was purely inherited, which made it resolve tonode_modules/@docusaurus/tsconfigand silently broke the alias.🤖 Generated with Claude Code