fix(cli): report vote list validator read failures as read_failed#1472
Merged
Conversation
Collaborator
|
please provide screenshots of the cli command working |
Contributor
Author
|
@anderdc I've attached cli command working screenshots in PR description. Please review again. |
anderdc
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1471
Fix
gitt vote list --jsonso validator whitelist read failures no longer look like a successful empty whitelist.Changes:
ContractReadErrorfor trustworthy contract-read failure reporting.IssueCompetitionContractClient.get_validators()raise on failed raw reads, read exceptions, and malformed validator Vec payloads.vote listtoerror.type == "read_failed".None, read exception, malformed payload, and real empty whitelist.Verification (live
finney— real data, no mocks)Run against the live
finneynetwork using the exact contract addresses from #1471:5DU266Ac3kVL6b3gGKNVqQ467WAq4JpucRAwxU1z9B98Bkavget_validatorsread fails5FWNdk8YNtNcHKrAx2krqenFrFAZG7vmsd2XN2isJSew3MrDBefore / After — failed read
Same failed-read contract, same command. Before this PR a failed read was reported as a successful empty whitelist (
success: true, exit 0); after it is correctly surfaced asread_failed(exit 1).Regression check — real whitelist still reads correctly
A genuine read against the real issues contract is unchanged: it still succeeds and returns the live validator (
success: true, exit 0).Testing
uv run --extra dev pytestuv run --extra dev ruff check .uv run --extra dev ruff format --check .uv run --extra dev pyright