fix(mirror): guard ISSUE_CLOSURE solved_by_pr write when issue was reopened#200
Open
andriypolanski wants to merge 1 commit into
Open
fix(mirror): guard ISSUE_CLOSURE solved_by_pr write when issue was reopened#200andriypolanski wants to merge 1 commit into
andriypolanski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISSUE_CLOSUREwrites withWHERE state = 'CLOSED'so a slow GraphQL fetch cannot repopulatesolved_by_prafter a reopen webhook cleared it.OPEN.Related Issues
Fixes #199
Type of Change
Testing
npm run buildinpackages/daspassesnpm run lintpassesnpm run test -- fetch.processor.spec.tspassessolved_by_prwritten when issue remainsCLOSEDafter fetchaffected === 0)solved_by_prcleared when job starts withOPENissueChecklist