Skip to content

Handle repo label rename/delete #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MkDev11 wants to merge 1 commit into
base: test
Choose a base branch
from
+252 −2
Open

Handle repo label rename/delete #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
252 changes: 251 additions & 1 deletion packages/das/src/webhook/handlers/label.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-explicit-any */
import { Injectable } from "@nestjs/common";
import { InjectRepository } from "@nestjs/typeorm";
import { Repository } from "typeorm";
import { DataSource, Repository } from "typeorm";
import { LabelEvent, Issue, PullRequest } from "../../entities";

@Injectable()
Expand All @@ -13,6 +13,7 @@ export class LabelHandler {
private readonly issueRepo: Repository<Issue>,
@InjectRepository(PullRequest)
private readonly prRepo: Repository<PullRequest>,
private readonly dataSource: DataSource,
) {}

/**
Expand Down Expand Up @@ -74,4 +75,253 @@ export class LabelHandler {
);
}
}

/**
* Called for repository-level label.deleted and label.edited events.
* GitHub applies these transitions repo-wide, so mirror the current
* target-level label state with per-target events for the scoring views.
*/
async handleRepoLabel(payload: Record<string, any>): Promise<void> {
const action = payload.action;
if (action !== "deleted" && action !== "edited") return;

const repoFullName: string | undefined = payload.repository?.full_name;
const labelName: string | undefined = payload.label?.name;
if (!repoFullName || !labelName) return;

const sender = payload.sender;
const actorGithubId = sender?.id != null ? String(sender.id) : null;
const actorLogin = sender?.login ?? null;
const timestamp = new Date().toISOString();

if (action === "deleted") {
await this.removeRepoLabel(
repoFullName,
labelName,
actorGithubId,
actorLogin,
timestamp,
);
return;
}

const oldName: string | undefined = payload.changes?.name?.from;
if (!oldName || oldName === labelName) return;

await this.renameRepoLabel(
repoFullName,
oldName,
labelName,
actorGithubId,
actorLogin,
timestamp,
);
}

private async removeRepoLabel(
repoFullName: string,
labelName: string,
actorGithubId: string | null,
actorLogin: string | null,
timestamp: string,
): Promise<void> {
await this.dataSource.transaction(async (manager) => {
await manager.query(
`
WITH latest_events AS (
SELECT DISTINCT ON (
le.repo_full_name,
le.target_number,
le.target_type,
le.label_name
)
le.repo_full_name,
le.target_number,
le.target_type,
le.action
FROM label_events le
WHERE le.repo_full_name = $1
AND le.label_name = $2
AND le.target_type IN ('pr', 'issue')
ORDER BY
le.repo_full_name,
le.target_number,
le.target_type,
le.label_name,
le.timestamp DESC
),
current_targets AS (
SELECT repo_full_name, target_number, target_type
FROM latest_events
WHERE action = 'labeled'
)
INSERT INTO label_events (
repo_full_name,
target_number,
target_type,
label_name,
action,
actor_github_id,
actor_login,
timestamp
)
SELECT
repo_full_name,
target_number,
target_type,
$2::varchar,
'unlabeled',
$3::varchar,
$4::varchar,
$5::timestamptz
FROM current_targets
ON CONFLICT DO NOTHING
`,
[repoFullName, labelName, actorGithubId, actorLogin, timestamp],
);

await manager.query(
`
UPDATE pull_requests
SET labels = array_remove(labels, $2)
WHERE repo_full_name = $1
AND $2 = ANY(labels)
`,
[repoFullName, labelName],
);

await manager.query(
`
UPDATE issues
SET labels = array_remove(labels, $2)
WHERE repo_full_name = $1
AND $2 = ANY(labels)
`,
[repoFullName, labelName],
);
});
}

private async renameRepoLabel(
repoFullName: string,
oldName: string,
newName: string,
actorGithubId: string | null,
actorLogin: string | null,
timestamp: string,
): Promise<void> {
await this.dataSource.transaction(async (manager) => {
await manager.query(
`
WITH latest_events AS (
SELECT DISTINCT ON (
le.repo_full_name,
le.target_number,
le.target_type,
le.label_name
)
le.repo_full_name,
le.target_number,
le.target_type,
le.action,
le.actor_github_id,
le.actor_login
FROM label_events le
WHERE le.repo_full_name = $1
AND le.label_name = $2
AND le.target_type IN ('pr', 'issue')
ORDER BY
le.repo_full_name,
le.target_number,
le.target_type,
le.label_name,
le.timestamp DESC
),
current_targets AS (
SELECT
repo_full_name,
target_number,
target_type,
actor_github_id,
actor_login
FROM latest_events
WHERE action = 'labeled'
),
transition_rows AS (
SELECT
repo_full_name,
target_number,
target_type,
$2::varchar AS label_name,
'unlabeled'::varchar AS action,
$4::varchar AS actor_github_id,
$5::varchar AS actor_login,
$6::timestamptz AS timestamp
FROM current_targets

UNION ALL

SELECT
repo_full_name,
target_number,
target_type,
$3::varchar AS label_name,
'labeled'::varchar AS action,
actor_github_id,
actor_login,
$6::timestamptz AS timestamp
FROM current_targets
)
INSERT INTO label_events (
repo_full_name,
target_number,
target_type,
label_name,
action,
actor_github_id,
actor_login,
timestamp
)
SELECT
repo_full_name,
target_number,
target_type,
label_name,
action,
actor_github_id,
actor_login,
timestamp
FROM transition_rows
ON CONFLICT DO NOTHING
`,
[repoFullName, oldName, newName, actorGithubId, actorLogin, timestamp],
);

await manager.query(
`
UPDATE pull_requests
SET labels = CASE
WHEN $3 = ANY(labels) THEN array_remove(labels, $2)
ELSE array_replace(labels, $2, $3)
END
WHERE repo_full_name = $1
AND $2 = ANY(labels)
`,
[repoFullName, oldName, newName],
);

await manager.query(
`
UPDATE issues
SET labels = CASE
WHEN $3 = ANY(labels) THEN array_remove(labels, $2)
ELSE array_replace(labels, $2, $3)
END
WHERE repo_full_name = $1
AND $2 = ANY(labels)
`,
[repoFullName, oldName, newName],
);
});
}
}
2 changes: 1 addition & 1 deletion packages/das/src/webhook/webhook.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class WebhookService {
await this.reviewCommentHandler.handle(payload);
break;
case "label":
// Repo-level label CRUD — not used for scoring, skip
await this.labelHandler.handleRepoLabel(payload);
break;
default:
this.logger.debug(`Unhandled event type: ${event}`);
Expand Down
Loading