Enforces Unique Plugin IDs in the Plugin Loader#82
Merged
mdwigley merged 1 commit intoenterlucent:mainfrom Sep 6, 2025
mdwigley:issue#81-mdwigley
Merged
Enforces Unique Plugin IDs in the Plugin Loader#82mdwigley merged 1 commit intoenterlucent:mainfrom mdwigley:issue#81-mdwigley
mdwigley merged 1 commit intoenterlucent:mainfrom
mdwigley:issue#81-mdwigley
Conversation
mdwigley
added a commit
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change enhances the plugin loading process by enforcing the uniqueness of PluginID metadata. During plugin grouping, the loader now tracks seen PluginIDs using a HashSet and excludes duplicate plugins, logging a warning for each duplicate detected. This helps prevent ambiguous or conflicting plugin identification that could arise from duplicated PluginIDs across different assemblies.
Related Issue
Motivation and Context
Currently, the plugin loader does not validate or enforce unique PluginIDs, assuming assemblies provide uniqueness implicitly. This assumption can cause conflicts and unpredictable behavior when plugins share IDs. This change aligns the loader behavior with the expected uniqueness constraint, improving robustness and maintainability of the plugin system.
How Has This Been Tested?
The change was tested by loading multiple plugins with both unique and duplicate PluginIDs to verify that duplicates are detected, logged as warnings, and not added multiple times. Existing test methods are expected to be updated for comprehensive validation alongside other relevant PRs.
Screenshots (if appropriate):
Types of changes
Checklist: