Skip to content

Renamed ProvidesDescriptorAttribute to DescriptorProviderAttribute#63

Merged
mdwigley merged 1 commit intoenterlucent:mainfrom
mdwigley:issue#62-mdwigley
Sep 3, 2025
Merged

Renamed ProvidesDescriptorAttribute to DescriptorProviderAttribute#63
mdwigley merged 1 commit intoenterlucent:mainfrom
mdwigley:issue#62-mdwigley

Conversation

@mdwigley
Copy link
Member

@mdwigley mdwigley commented Sep 3, 2025

Description

Renamed ProvidesDescriptorAttribute to DescriptorProviderAttribute in PlugHub.Shared/Attributes.
This includes:

  • Updating the file name to DescriptorProviderAttribute.cs
  • Replacing all references across the solution
  • Adjusting related tests and documentation

Related Issue

Motivation and Context

The new naming improves clarity and aligns with common .NET attribute naming conventions (noun-based + Attribute suffix).
This reduces confusion and makes the attribute’s purpose clearer to contributors.

How Has This Been Tested?

  • Built the solution successfully after renaming
  • Verified all unit tests pass
  • Performed a solution-wide search to confirm old references have been updated

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Asset change (adds or updates icons, templates, or other assets)
  • Documentation change (adds or updates documentation)
  • Plugin change (adds or updates a plugin)

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the core logic.
    • I have linked the project issue above.
  • My change requires a change to the assets.
    • I have linked the asset issue above.
  • My change requires a change to the documentation.
    • I have linked the documentation issue above.
  • My change requires a change to a plugin.
    • I have linked the plugin issue above.

@mdwigley mdwigley self-assigned this Sep 3, 2025
@mdwigley mdwigley added the approved Change issue has been accepted for implementation label Sep 3, 2025
@mdwigley mdwigley moved this to In progress in PlugHub Timeline Sep 3, 2025
@mdwigley mdwigley merged commit 97025c5 into enterlucent:main Sep 3, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in PlugHub Timeline Sep 3, 2025
@mdwigley mdwigley deleted the issue#62-mdwigley branch September 3, 2025 13:42
mdwigley added a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Change issue has been accepted for implementation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rename ProvidesDescriptorAttribute to DescriptorProviderAttribute

1 participant

Comments