feature - add execution observations and adapter coverage checks (#66, #67)#85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds RFC 032 execution observations for
Session.execute,Session.collect, andSession.writewhile preserving the existingResult[...]APIs. It also adds the first RFC 033 adapter coverage surface: explicit adapter requirements, conservative coverage records, andSession.check_coverage(...)for requirements supplied by callers.Type of change
docs/rfcs/*)Area(s)
Select the primary areas touched (labels sync from checked lines when the triage workflow runs):
Key details
Sessionnow exposesexecute_observed,collect_observed, andwrite_observedmethods that return observed result carriers withdata,observation, anderrorfields. Observations include plan and execution-attempt targets, client-session context, backend name, status, diagnostics, wall-clock and monotonic timing, optional row/byte counts, adapter/profile placeholders, trace IDs, and linked coverage records.execute,collect, andwritemethods, so legacy callers keep the sameResult[...]behavior. Prism plan IDs are centralized throughprism_plan_id(...)so inspection and execution evidence do not diverge. Adapter coverage is conservative: unknown stays unknown, DataFusion only reports the capability families this slice can justify, and unsupported backend capability is not modeled as Substrait semantics.Testing / verification
make ci(ormake fmt-check,make build,make test)Manual verification notes:
make pre-commit INCAN=/Users/danny/Development/encero/tmp/incan-v03-verify/target/debug/incanpassed with Incan0.3.0: fmt-check, test-style, vocab companion tests, registry metadata, build, and all 256 InQL tests./Users/danny/Development/encero/tmp/incan-v03-verify/target/debug/incan test tests/test_execution_observations.incnpassed: 7 focused tests.git diff --check HEAD^..HEADpassed.incansymlink to mirror CI's sibling Incan checkout required byvocab_companion; the symlink was removed afterwards.Docs impact
If docs updated:
docs/language/reference/execution_context.md,docs/language/reference/inspection.md,docs/release_notes/v0_1.md,docs/rfcs/032_execution_observations.md,docs/rfcs/033_adapter_requirements_coverage.md,docs/rfcs/README.mdChecklist
Refs #66
Refs #67