feat: nvim-cmp icon

[eeeXun]

nvim-cmp separates icon highight in hrsh7th/nvim-cmp#2190

Summary by CodeRabbit

• New Features
  • Added icon-specific highlight variants for completion item kinds in the Gruvbox theme, expanding visual support for code completion UI with dedicated highlighting for various symbol categories including functions, methods, classes, variables, modules, interfaces, enums, operators, keywords, references, snippets, and file system elements.

[coderabbitai]

Walkthrough

Icon-specific highlight variants added to the Gruvbox Neovim plugin's completion item kind definitions. Approximately 25 new CmpItemKind*Icon entries are introduced, each linked to their respective base highlight group counterparts, expanding UI icon highlighting support without removing existing definitions.

Changes

Cohort / File(s)

Summary

Gruvbox CmpItemKind Icon Variants lua/gruvbox.lua

Added 25 new highlight link definitions for CmpItemKind icon variants (CmpItemKindTextIcon, CmpItemKindVariableIcon, CmpItemKindMethodIcon, CmpItemKindFunctionIcon, CmpItemKindConstructorIcon, CmpItemKindUnitIcon, CmpItemKindFieldIcon, CmpItemKindClassIcon, CmpItemKindInterfaceIcon, CmpItemKindModuleIcon, CmpItemKindPropertyIcon, CmpItemKindValueIcon, CmpItemKindEnumIcon, CmpItemKindOperatorIcon, CmpItemKindKeywordIcon, CmpItemKindEventIcon, CmpItemKindReferenceIcon, CmpItemKindColorIcon, CmpItemKindSnippetIcon, CmpItemKindFileIcon, CmpItemKindFolderIcon, CmpItemKindEnumMemberIcon, CmpItemKindConstantIcon, CmpItemKindStructIcon, CmpItemKindTypeParameterIcon), each mapping to their non-Icon counterpart.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

• Homogeneous, repetitive pattern across all 25 additions
• Mechanical link definitions with no logic changes
• Single file modification with straightforward intent

Poem

🐰 Icons bloom in gruvbox's garden bright,
Twenty-five new variants catch the light,
Each linked and paired with careful care,
Completion items dressed in colors fair! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "feat: nvim-cmp icon" is related to the changeset, which adds icon-specific highlight variants (CmpItemKindTextIcon, CmpItemKindVariableIcon, and others) for the Gruvbox Neovim plugin's support of nvim-cmp. The title accurately identifies the component (nvim-cmp) and the aspect being modified (icons/icon highlights). While the title is somewhat brief and general rather than providing granular details about the specific nature of the changes (adding icon-variant highlight links), it is sufficiently clear and meaningful to convey the primary purpose of the PR to someone reviewing commit history.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e0a460 and b2c52f7.

📒 Files selected for processing (1)

• lua/gruvbox.lua (1 hunks)

🔇 Additional comments (1)

lua/gruvbox.lua (1)

536-560: LGTM! Clean implementation of nvim-cmp icon highlighting support.

The Icon variant highlight groups are correctly implemented with proper linking to their base counterparts. All 25 CmpItemKind types have corresponding Icon variants, providing complete coverage for nvim-cmp's separated icon highlighting feature introduced in hrsh7th/nvim-cmp#2190.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DavidTelenko]

@ellisonleao is there any problems with this PR, can we merge this?

[DavidTelenko]

Here's the snippet as a temporary solution:

for name in pairs(require('cmp.types').lsp.CompletionItemKind) do
  if type(name) == 'string' then
    local hl_group = ('CmpItemKind%s'):format(name)
    vim.api.nvim_set_hl(0, hl_group .. 'Icon', {
      link = hl_group,
    })
  end
end