chore: Remove dead code and park chat onboarding - #3920
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: elie222/inbox-zero/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (68)
💤 Files with no reviewable changes (63)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe change removes chat onboarding and several mail, assistant, discovery, and landing-page features. It also deletes supporting tests, validation, storage and integration utilities, and development setup files. Assistant result components now use locally defined types. ChangesChat onboarding
Mail and assistant actions
Discovery and AI helpers
App surfaces
Landing-page content
Slack reactions
Account and storage helpers
Tinybird delete operation
Development setup files
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk was established; the checked-in image workflows do not depend on the removed web Dockerfile. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Removing the onboarding route and unused capabilities appears to reduce exposed functionality. The remaining assistant components display legacy rule results rather than adding a way to execute the retired tools. Deployment behavior and some upstream controls were not fully verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
elie222
added this pull request to stack #3927
September 28, 2026 17:11
elie222
force-pushed
the
cleanup/remove-dead-code
branch
4 times, most recently
from
September 28, 2026 18:11
fb59f20 to
021ffe1
Compare
elie222
force-pushed
the
cleanup/remove-dead-code
branch
2 times, most recently
from
September 28, 2026 18:25
826b734 to
a484a36
Compare
elie222
force-pushed
the
cleanup/remove-dead-code
branch
from
September 28, 2026 18:46
a484a36 to
7a5545c
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…, and stale skills Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Restores the components and text helpers the marketing site imports and the user-invoked skills. Removes the chat onboarding API route, prompt, answers action and feature flag hook, which only the parked UI used; the full feature is kept on the parked/chat-onboarding branch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
elie222
force-pushed
the
cleanup/remove-dead-code
branch
from
September 28, 2026 18:56
7a5545c to
7013d22
Compare
elie222
changed the title
elie222
marked this pull request as ready for review
September 28, 2026 20:47
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a codebase cleanup stack.
Removes code with no production importers. Checked by import path across this repo (including dynamic imports and test mocks) and against every
@/import in the marketing repo, which is cloned intoapp/(marketing)at build time.Parked, not lost: the chat onboarding experiment (UI,
/api/chat/onboardingroute, prompt, answers action, feature-flag hook, LLM use case) is removed from main and kept whole on theparked/chat-onboardingbranch, so it can come back when it goes live.Removed:
ManageSplitsDialog,RuleTab,useModifierKey,ai-elements/actions.docker/Dockerfile.webandsetup.sh.Kept on purpose:
PricingLazy,Banner,LegalPageandutils/text(used by the marketing site), thewaitandwrite-testsskills (user-invoked), the paused follow-up draft cleanup, the Tinybird delete module (rewritten in #3933), and theai/summarise/ai/compose-autocompleteroutes.Validation: non-test type check clean; all marketing
@/imports resolve; related tests pass.🤖 Generated with Claude Code
Summary by CodeRabbit