Skip to content

Delay process end notification#994

Merged
danirabbit merged 1 commit intomainfrom
jeremypw/delay-notification
Feb 18, 2026
Merged

Delay process end notification#994
danirabbit merged 1 commit intomainfrom
jeremypw/delay-notification

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Feb 17, 2026

Fixes #947

Do not send notification in case of temporary focus out.

@jeremypw jeremypw requested a review from danirabbit February 17, 2026 11:37
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm the OP's issue, but if you can reproduce it I believe you that this fixes it :) I'm not a massive fan of magic number timeouts, but it seems fine ✔️

@danirabbit danirabbit merged commit 43a7411 into main Feb 18, 2026
4 checks passed
@danirabbit danirabbit deleted the jeremypw/delay-notification branch February 18, 2026 16:52
@jeremypw
Copy link
Collaborator Author

jeremypw commented Feb 18, 2026

I agree. I am thinking of replacing this DBus message (which requires complicated messing with the prompt) with a simpler method of polling to detect start of finish of processes and hopefully that will not require this fix. That would be for a later release though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process completed notification while terminal is focused

2 participants

Comments