fix(pglite-sync): don't filter move-in messages by LSN #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move-in messages from Electric's
tagged_subqueriesfeature don't have anlsnheader because they come from direct database queries, not from the PostgreSQL replication stream. Previously, these messages were incorrectly skipped as "already seen" because the missing LSN defaulted to 0.This fix checks for the
is_move_inheader and bypasses LSN filtering for move-in messages, ensuring that rows moving into a shape due to subquery condition changes are properly synced to the client.Problem
When using shapes with subqueries (e.g.,
WHERE id IN (SELECT user_id FROM workspace_members WHERE workspace_id = $1)), new rows that "move in" to match the subquery weren't being synced:headers.is_move_in: truebut NOheaders.lsn(since it's from a query, not replication)lsn <= lastCommittedLsnForShapeevaluates to0 <= Xwhich is true after initial syncSolution
Test case
id IN (SELECT user_id FROM workspace_members WHERE workspace_id = ...))