Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The SLO template structure looks correct for format_version 3.5.0, but there are field name mismatches that will prevent the SLO from working correctly.
Field Name Issues:
The SLO template uses field names without the metrics. prefix, but the existing dashboard in this package uses the full field paths:
| SLO Template Uses | Dashboard Uses |
|---|---|
apache.request.time |
metrics.apache.request.time |
apache.requests |
metrics.apache.requests |
apache.server.name |
resource.attributes.apache.server.name |
These mismatches will cause the SLO to not find any data, resulting in 0% compliance or errors.
Please verify the actual field names in your Elasticsearch indices and update the SLO template to match. Looking at the dashboard file (kibana/dashboard/apache_otel-b536d9d2-90f0-4177-a92e-adbe6e12427d.json), the correct field names appear to include the prefixes.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| { | ||
| "name": "A", | ||
| "aggregation": "max", | ||
| "field": "apache.request.time", |
There was a problem hiding this comment.
🟠 HIGH Incorrect field name - should include 'metrics.' prefix
Why: The dashboard uses 'metrics.apache.request.time' but this SLO uses 'apache.request.time'. This will cause the SLO to not find any data and always show 0% compliance.
| "field": "apache.request.time", | |
| "field": "metrics.apache.request.time", |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| { | ||
| "name": "B", | ||
| "aggregation": "min", | ||
| "field": "apache.request.time", |
There was a problem hiding this comment.
🟠 HIGH Incorrect field name - should include 'metrics.' prefix
Why: Same issue as line 15 - field name mismatch with actual Elasticsearch data.
| "field": "apache.request.time", | |
| "field": "metrics.apache.request.time", |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| { | ||
| "name": "C", | ||
| "aggregation": "max", | ||
| "field": "apache.requests", |
There was a problem hiding this comment.
🟠 HIGH Incorrect field name - should include 'metrics.' prefix
Why: The dashboard uses 'metrics.apache.requests' (see line 189 of the dashboard JSON). This mismatch will cause the SLO to not find data.
| "field": "apache.requests", | |
| "field": "metrics.apache.requests", |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| { | ||
| "name": "D", | ||
| "aggregation": "min", | ||
| "field": "apache.requests", |
There was a problem hiding this comment.
🟠 HIGH Incorrect field name - should include 'metrics.' prefix
Why: Same issue as line 27 - field name mismatch with actual Elasticsearch data.
| "field": "apache.requests", | |
| "field": "metrics.apache.requests", |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| "otel" | ||
| ], | ||
| "groupBy": [ | ||
| "apache.server.name" |
There was a problem hiding this comment.
🟠 HIGH Incorrect field name for groupBy
Why: The dashboard uses 'resource.attributes.apache.server.name' (see lines 629, 899, 1045, 1406). Using incorrect field name will break grouping.
| "apache.server.name" | |
| "resource.attributes.apache.server.name" |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
💔 Build Failed
Failed CI StepsHistory |
There was a problem hiding this comment.
The SLO template has field name mismatches that will prevent it from finding any data in Elasticsearch. All 5 issues were already flagged in the previous review and remain unaddressed:
-
Metric field names (lines 15, 21, 27, 33): OTel metrics are indexed with a
metrics.prefix. The fields should be:metrics.apache.request.timeinstead ofapache.request.timemetrics.apache.requestsinstead ofapache.requests
-
groupBy field (line 59): Server name uses a different path in OTel format:
resource.attributes.apache.server.nameinstead ofapache.server.name
These field name mismatches are confirmed by examining the existing dashboard (apache_otel-b536d9d2-90f0-4177-a92e-adbe6e12427d.json), which correctly uses the metrics. prefix and resource.attributes. path.
Please address the suggestions in the existing inline comments.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
3 participants
Proposed commit message
Add SLO template for Apache otel content pack
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package build && elastic-package stack up -v -d --services package-registryScreenshots