Updates to OTel VPC Flow Log Dashboard + YAML Dashboard Validator #17358
Conversation
- Update version in manifest.yml from 0.1.1 to 0.2.0 - Add changelog entry documenting the VPC Flow Log dashboard updates Co-authored-by: Bill Easton <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changelog PR link issue has already been flagged in an unresolved comment (line 5 of packages/aws_vpcflow_otel/changelog.yml - links to #16969 but should be #17358).
Previous review comments on the workflow file have been addressed:
- PyPI packages are now pinned to specific version (
@0.2.7) instead of@latest - The
diff -rcomparison approach was replaced with--exit-non-zero-on-changeflag
The implementation looks sound overall - the YAML dashboard validation workflow and the _dev folder removal for content packages follow existing patterns in the codebase.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
dashboard
teresaromero
left a comment
teresaromero
left a comment
There was a problem hiding this comment.
Changes lgtm, however i'd like to get some extra eyes 👀
|
@claude address pr feedback |
|
Claude finished @strawgate's task in 1m 0s —— View job Addressing PR Feedback
Done! I've addressed the PR feedback:
Changes pushed in commit b504f36. --- | View branch Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Co-authored-by: Bill Easton <[email protected]>
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
4 participants
Updates to the OTel VPC Flow Log Dashboard + YAML version of dashboard leveraging https://github.com/strawgate/kb-yaml-to-lens
Removes _dev folder from content packs during build
Iterating on the actual panels here strawgate/kb-yaml-to-lens#914
Overview
Interface Analysis
Traffic Analysis
Current Dashboard on Main
The following is the dashboard on main that is being replaced
