Repository navigation
feat(vad): route the Silero VAD session through the EP-aware builder; CoreML full-coverage smoke - #35
Merged
Merged
Conversation
… CoreML full-coverage smoke The Silero VAD session was the last ort::Session built outside onnx::build_session_with_ep — the one diarization-path session that could not honor a selected execution provider. - SileroVad::with_ep(path, chunk_size, ep) builds through the shared helper (header validation + warn-and-CPU-fallback for unwired providers, same as every other session). new() keeps its signature and the historical CPU default, per the module contract's escalation policy; the contract records the change. - New macOS-aarch64 + coreml integration test (coreml_full_pipeline_smoke, #[ignore], needs the model cache): builds the full v2 pipeline with ExecutionProvider::CoreMl, diarizes the bundled clip end-to-end, and runs a CoreML VAD session — proving every ONNX session accepts the EP. Passes locally on M1 in 8s. - Session audit is now clean: the only Session::builder call in src/ lives inside build_session_with_ep. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ekhodzitsky
added a commit
that referenced
this pull request
Jul 31, 2026
… CoreML full-coverage smoke (#35) The Silero VAD session was the last ort::Session built outside onnx::build_session_with_ep — the one diarization-path session that could not honor a selected execution provider. - SileroVad::with_ep(path, chunk_size, ep) builds through the shared helper (header validation + warn-and-CPU-fallback for unwired providers, same as every other session). new() keeps its signature and the historical CPU default, per the module contract's escalation policy; the contract records the change. - New macOS-aarch64 + coreml integration test (coreml_full_pipeline_smoke, #[ignore], needs the model cache): builds the full v2 pipeline with ExecutionProvider::CoreMl, diarizes the bundled clip end-to-end, and runs a CoreML VAD session — proving every ONNX session accepts the EP. Passes locally on M1 in 8s. - Session audit is now clean: the only Session::builder call in src/ lives inside build_session_with_ep. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ekhodzitsky
added a commit
that referenced
this pull request
Jul 31, 2026
… CoreML full-coverage smoke (#35) The Silero VAD session was the last ort::Session built outside onnx::build_session_with_ep — the one diarization-path session that could not honor a selected execution provider. - SileroVad::with_ep(path, chunk_size, ep) builds through the shared helper (header validation + warn-and-CPU-fallback for unwired providers, same as every other session). new() keeps its signature and the historical CPU default, per the module contract's escalation policy; the contract records the change. - New macOS-aarch64 + coreml integration test (coreml_full_pipeline_smoke, #[ignore], needs the model cache): builds the full v2 pipeline with ExecutionProvider::CoreMl, diarizes the bundled clip end-to-end, and runs a CoreML VAD session — proving every ONNX session accepts the EP. Passes locally on M1 in 8s. - Session audit is now clean: the only Session::builder call in src/ lives inside build_session_with_ep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last gap in EP coverage: the Silero VAD session was the only
ort::Sessionstill built outsideonnx::build_session_with_ep, so it could not honor a selected execution provider while every other session could.What changed
SileroVad::with_ep(path, chunk_size, ep)— the session goes through the shared EP-aware builder (header validation before ort, warn-and-CPU-fallback for unwired providers, consistent with every other ONNX session).new()keeps its exact signature and the historical CPU default — the module contract's escalation item ("changes to constructor signature") is respected, and the contract documents the addition.coreml_full_pipeline_smoke— macOS-aarch64 +coremlintegration test (#[ignore], needs the model cache): builds the full v2 pipeline withExecutionProvider::CoreMl, diarizes the bundled 26s clip end-to-end, and runs a CoreML VAD session with real probability assertions. Proves no session is left silently on CPU when CoreML is requested (CoreML partitions unsupported ops to CPU per-session — expected and non-fatal).rg 'Session::builder' src/matches only insidebuild_session_with_ep.Verification
cargo nextest run --all-features: 425 passed; clippy-D warnings+ fmt clean.🤖 Generated with Claude Code