Handle WorkshopFileInfos.json#13
Open
KyleJamesWalker wants to merge 1 commit into
Open
Conversation
Owner
|
Sorry for letting this lie around stale for so long! This looks a bit too magical for my taste and I wonder whether this may make it easier for files passed on the command-line unintentionally to go unnoticed. I think the main expectation for command-line programs, when given a file of improper format, would be to complain early and loudly. I was wondering whether it would make sense to instead allow passing a directory name on the command-line, and in this case we could be more clever about which files we actually load. This way we don’t ignore files that, according to the command-line, should be processed, but running the tool on all of the files is still more convenient than before. |
This was referenced Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow running
tts-prefetch ~/Library/Tabletop\ Simulator/Mods/Workshop/*.jsonwithout an error.I generally just run the prefetch on my entire mods directory and it always errors out on the WorkshopFileinfos.json file
Example output: