Skip to content

Handle WorkshopFileInfos.json#13

Open
KyleJamesWalker wants to merge 1 commit into
eigengrau:masterfrom
KyleJamesWalker:master
Open

Handle WorkshopFileInfos.json#13
KyleJamesWalker wants to merge 1 commit into
eigengrau:masterfrom
KyleJamesWalker:master

Conversation

@KyleJamesWalker

Copy link
Copy Markdown
Contributor

Allow running tts-prefetch ~/Library/Tabletop\ Simulator/Mods/Workshop/*.json without an error.

I generally just run the prefetch on my entire mods directory and it always errors out on the WorkshopFileinfos.json file

Example output:

Skipping /Users/user.home/Library/Tabletop Simulator/Mods/Workshop/WorkshopFileInfos.json likely workshop file info

@eigengrau

Copy link
Copy Markdown
Owner

Sorry for letting this lie around stale for so long!

This looks a bit too magical for my taste and I wonder whether this may make it easier for files passed on the command-line unintentionally to go unnoticed. I think the main expectation for command-line programs, when given a file of improper format, would be to complain early and loudly.

I was wondering whether it would make sense to instead allow passing a directory name on the command-line, and in this case we could be more clever about which files we actually load. This way we don’t ignore files that, according to the command-line, should be processed, but running the tool on all of the files is still more convenient than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants