Skip to content

Remove offset from CI to investigate bug - #64

Closed
simonge wants to merge 2 commits into
mainfrom
Test-no-status-offset
Closed

simonge wants to merge 2 commits into
mainfrom
Test-no-status-offset

Conversation

@simonge

@simonge simonge commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Briefly, what does this PR introduce?

The CI capybara report has flagged up a number of unexpected differences between the two merging approaches. In particular:

The MCParticle.simulatorStatus has lots of additional DecayedInTracker flags when edm4hep merged.
https://eic.github.io/TimeframeBuilder/capybara/pr-61/index.html#MCParticles

Lots of additional VertexBarrelHits
https://eic.github.io/TimeframeBuilder/capybara/pr-61/index.html#VertexBarrelHits

Probably caused by the same issue. The two potential causes I can envisage are the generatorStatus not being 1 in the simulation has further implications for dd4hep than realised. The energy units of the hepmc3 files are different.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@simonge

simonge commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

Still some issues with the far forward hits but the main issue was the lack of "alternative stable particles" in npsim

@simonge

simonge commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

PR served CI testing purposes.

@simonge simonge closed this Jul 22, 2026

This branch was previously deployed

1 inactive deployment
github-pages — 14070c7f Deployed Feb 5, 2026 by simonge via deploy-docs #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant