Repository navigation
Conversation
Collaborator
Author
|
Still some issues with the far forward hits but the main issue was the lack of "alternative stable particles" in npsim |
Collaborator
Author
|
PR served CI testing purposes. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
The CI capybara report has flagged up a number of unexpected differences between the two merging approaches. In particular:
The MCParticle.simulatorStatus has lots of additional DecayedInTracker flags when edm4hep merged.
https://eic.github.io/TimeframeBuilder/capybara/pr-61/index.html#MCParticles
Lots of additional VertexBarrelHits
https://eic.github.io/TimeframeBuilder/capybara/pr-61/index.html#VertexBarrelHits
Probably caused by the same issue. The two potential causes I can envisage are the generatorStatus not being 1 in the simulation has further implications for dd4hep than realised. The energy units of the hepmc3 files are different.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?