Skip to content

feat: enabling easy theme translations (#2945)#6

Merged
deborahgu merged 2 commits intorelease-ulmofrom
enable-credentials-themes-translation-imports
Jan 28, 2026
Merged

feat: enabling easy theme translations (#2945)#6
deborahgu merged 2 commits intorelease-ulmofrom
enable-credentials-themes-translation-imports

Conversation

@deborahgu
Copy link
Member

@deborahgu deborahgu commented Jan 27, 2026

making it easy for local configuration to pull inextra configured translations, such as credentials-themes or any other plug-ins. Also updates pins pip per prior art to deal with a github-only, fork-only CI failure.

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

making it easy for local configuration to  pull inextra configured translations, such as credentials-themes  or any other plug-ins.
Copilot AI review requested due to automatic review settings January 27, 2026 14:34

This comment was marked as spam.

pinning pip per [prior art](openedx/enterprise-access#919). ci fails on our fork ut succeeds upstream and locally, and I don't know why but this is our established fix
Copilot AI review requested due to automatic review settings January 27, 2026 14:54

This comment was marked as abuse.

pip-sync requirements/dev.txt

piptools:
pip install -U 'pip<25.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nevermind, I just saw your description in the PR

@deborahgu deborahgu merged commit 644ae69 into release-ulmo Jan 28, 2026
11 checks passed
@deborahgu deborahgu deleted the enable-credentials-themes-translation-imports branch January 28, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants