feat: add Edly client branding settings to SiteConfiguration #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new JSONField for 'edly_client_branding_and_django_settings' in the SiteConfiguration model. - Updated the SiteConfigurationAdmin to include the new field in the admin interface. - Added a method to retrieve configuration values from the new field with error logging. This enhancement allows for better customization of the Edly client theme settings.
- Introduced a new CharField 'edx_org_short_name' to the SiteConfiguration model with unique constraints and help text for better organization identification. - Updated SiteConfigurationAdmin to include the new field in the admin interface. - Added a migration to create the new field in the database. This enhancement improves the ability to uniquely identify organizations within the system.
- Updated the filter_visible function to apply the _filter_visible_course_certificates directly to the queryset instead of filtering for non-null course credentials first. - we do not generate course cert against a program on credentials
credentials check if the certifciates are earned for course runs for a program however we do not want this. In our case program cert is only generated when user completes all courses on lms
muhammadali286
requested changes
Oct 8, 2025
…gs field - Changed the default value of the 'edly_client_branding_and_django_settings' JSONField in the SiteConfiguration model from an empty dictionary to the dict constructor for better clarity. - Added a migration to reflect this change in the database schema. This update enhances the model's configuration handling.
Waleed-Mujahid
force-pushed
the
waleed/init
branch
from
aebc611 to
63f536f
Compare
muhammadali286
approved these changes
Oct 8, 2025
Waleed-Mujahid
added a commit
that referenced
this pull request
Dec 3, 2025
feat: add Edly client branding settings to SiteConfiguration
Anas-hameed
pushed a commit
that referenced
this pull request
Jan 23, 2026
feat: add Edly client branding settings to SiteConfiguration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows for better customization of the Edly client theme settings.