Repository navigation
Package numerics fixtures and retain compatibility evidence - #1273
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR packages two canonical conformance fixtures (affine-clairvoyant.json and log-buy-sell-asymmetry.json) directly inside the voiage-numerics crate so the tests pass after archive extraction, and adds a new guard test (packaged_fixtures_match_repository_references_when_available) that verifies the crate copies stay in sync with the repository originals.
Overall assessment: The change is well-scoped and the approach is sound. One crash risk was identified in the new guard test — see the inline comment. The rest of the changes (import reordering, assert formatting, evidence records, changelog entries, and the C consumer witness) are correct and raise no blocking concerns.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…e-fixtures-20261105 # Conflicts: # changelog.md
…e-fixtures-20261105 # Conflicts: # changelog.md
The numerics crate's extracted tests previously depended on fixtures outside the published archive. This includes the two canonical fixtures in the crate and checks them against the repository copies when available.
It also retains bounded engineering evidence for Rust API comparisons, a C consumer, and private R and Julia binding checks. Those observations do not close the full feature/target matrix, registry acceptance, or the parent engineering review.
Validation so far: focused Rust tests, offline Cargo package verification, extracted-archive tests using local dependency patches, Rust 1.85 test-target compilation, and the repository reference-policy check passed. The full local gate and current-head hosted checks remain required. Merge after the reconciliation PR and its gates.