Issue #314: Temporary relations are left vulnerable to garbage collection#315
Open
hazzabeee wants to merge 1 commit intoedbmods:masterfrom
Open
Issue #314: Temporary relations are left vulnerable to garbage collection#315hazzabeee wants to merge 1 commit intoedbmods:masterfrom
hazzabeee wants to merge 1 commit intoedbmods:masterfrom
Conversation
… collection I am not absolutely sure the changes to Controller are required since RelationshipBuilder should be adding the temporary pawns to the world anyway (and killing them). To consider: whether changes are needed for hidden pawns (same bug seems to occur but is a bit more complex to debug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not absolutely sure the changes to Controller are required since
RelationshipBuilder should be adding the temporary pawns to the world
anyway (and killing them).
To consider: whether changes are needed for hidden parents (same bug
seems to occur but is a bit more complex to debug).