Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #141 +/- ##
===========================================
- Coverage 30.03% 30.01% -0.02%
===========================================
Files 34 34
Lines 6177 6180 +3
Branches 742 743 +1
===========================================
Hits 1855 1855
- Misses 4293 4296 +3
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7a9ce20 to
388632a
Compare
Member
Author
|
OK, @shahramn, I've tested the deployment of this (platform agnostic wheels) on https://test.pypi.org/project/eccodes/#files and it looks good to me. A 'normal' install will bring in eccodeslib, and a --no-binary install will not. Feel free to merge when you're happy to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes ecmwf/eccodes#372. The only change in behaviour that might not be expected is that now a developer who clones the eccodes-python repo and does
pip install -e .will not get eccodeslib installed automatically - they will have to manually install it if they wish it to be there.Contributor Declaration
By opening this pull request, I affirm the following: